Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1375 empty headings fallback #1385

Merged
merged 4 commits into from
Nov 25, 2023
Merged

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Nov 22, 2023

Description

When data contains an empty heading/key, the value for that column will be preselected under “Pagination URL” on the “Element” page and in the field mapping on the “Map” page.

  • Google Sheet and CSV: those data types are 2 dimensional, so solved by adding blank_heading_<column_index_number> as the heading
Screenshot 2023-11-22 at 16 00 39
  • XML: doesn’t allow empty node names, so this problem doesn’t exist there.
Screenshot 2023-11-22 at 15 58 49
  • Atom and RSS: both use the same processing as XML.
  • Json: because this can be deeply nested, I opted for throwing an error if empty keys are found.
Screenshot 2023-11-22 at 16 01 21

Applicable to v4 and v5.

Related issues

#1375

@i-just i-just requested a review from angrybrad as a code owner November 22, 2023 16:05
@angrybrad angrybrad merged commit 9db43f8 into v4 Nov 25, 2023
5 checks passed
@angrybrad angrybrad deleted the bugfix/1375-empty-headings-fallback branch November 25, 2023 03:10
angrybrad added a commit that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants