Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

order of events for setting enabled & enabledForSite #1381

Merged
merged 1 commit into from
Nov 25, 2023
Merged

order of events for setting enabled & enabledForSite #1381

merged 1 commit into from
Nov 25, 2023

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Nov 17, 2023

Description

Process enabled and enabledForSite attributes before bulk-setting the rest of element attributes.

Related issues

#1208

@i-just i-just requested a review from angrybrad as a code owner November 17, 2023 13:17
@angrybrad angrybrad merged commit 8ac5f92 into v4 Nov 25, 2023
5 checks passed
@angrybrad angrybrad deleted the bugfix/1208-element-enabled-attribute branch November 25, 2023 02:52
angrybrad added a commit that referenced this pull request Nov 25, 2023
@angrybrad
changelog for #1381
62918d8
@angrybrad angrybrad mentioned this pull request Nov 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angrybrad angrybrad Awaiting requested review from angrybrad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-just @angrybrad