Bugfix/1499 inner element fields #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where mapping inner fields for an entry field wasn't showing the correct fields.
It was initially fixed here: 5a75e50 but then the pre-fix approach was used when updating to Craft 4 66a2257.
Adds missing "simple" fields that can be used when mapping an element field.
@angrybrad, for Feed Me v6, the list under
src/web/twig/variables/FeedMeVariable.php::supportedSubField()should also containIcon::class,(where Icon iscraft\fields\Icon). Let me know if you'd like me to raise a separate PR for v6 or if you're okay with adding that in when merging branches.Related issues
#1499