[5369] Design and implement a Recycle Bin #3126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rart
requested changes
Aug 24, 2022
| @@ -97,6 +99,7 @@ export function ActionsBar(props: ActionsBarProps) { | |||
| disabled={disabled} | |||
| {...buttonProps} | |||
| onClick={() => onOptionClicked(option.id)} | |||
| startIcon={option.icon ? <SystemIcon icon={option.icon} /> : null} | |||
| @@ -83,7 +83,7 @@ const states = { | |||
| disabled: { stateMap: { disabled: true } } | |||
| }; | |||
|
|
|||
| const status = { | |||
| export const status = { | |||
There was a problem hiding this comment.
This needs a much better name if it is to be exported
Comment on lines
52
to
58
| const id = systemLinkId === 'siteDashboardDialog' ? 'craftercms.components.Dashboard' : ( | ||
| systemLinkId === 'siteToolsDialog' | ||
| ? 'craftercms.components.EmbeddedSiteTools' | ||
| : systemLinkId === 'siteRecycleBin' | ||
| ? 'craftercms.components.RecycleBin' | ||
| : 'craftercms.components.Search' | ||
| ); |
| import { makeStyles } from 'tss-react/mui'; | ||
| import { Theme } from '@mui/material/styles'; | ||
|
|
||
| export const useStyles = makeStyles()((theme: Theme) => ({ |
|
|
||
| import { defineMessages } from 'react-intl'; | ||
|
|
||
| export const translations = defineMessages({ |
There was a problem hiding this comment.
I believe we can now define messages inline with the react-intl upgrade
| }, | ||
| itemsTable: { | ||
| border: 'none !important', | ||
| '& .MuiDataGrid-columnHeaders, & .MuiDataGrid-cell, & .MuiDataGrid-cell--withRenderer & .MuiDataGrid-footerContainer': |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
craftercms/craftercms#5369