Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6633] Remove all logical resources from code #3869

Draft
wants to merge 31 commits into
base: develop
Choose a base branch
from
Draft

[6633] Remove all logical resources from code #3869

wants to merge 31 commits into from

Conversation

jvega190
Copy link
Member

@jvega190
[6633] Remove logicalResource from ConflictedPathDiffDialog
81469ca
@jvega190
[6633] Remove logicalResource from PreviewPageExplorerPanel.tsx
4eec135
@jvega190
[6633] Remove logicalResource from SiteManagement
b8e510b
@jvega190
Merge branch 'develop' of https://github.com/craftercms/studio-ui int…
6337966 
…o enhancement/6633

# Conflicts:
#	ui/app/src/components/PreviewPageExplorerPanel/PreviewPageExplorerPanel.tsx
@jvega190
[6633] Remove logicalResource from NewContentDialog
57932d9
@jvega190
[6633] Remove logicalResource from PreviewDropTargetsPanel
576214d
@jvega190
[6633] Remove logicalResource from PreviewPageExplorerPanel
dd5da3c
@jvega190
[6633] Remove logicalResource from DeleteContentTypeDialog
a199d9e
@jvega190
[6633] Remove logicalResource from UninstallPluginDialog
c70e786
@jvega190
[6633] Remove unused imports
0476aef
@jvega190
[6633] Remove logicalResource from QuickCreate, delete pages/QuickCre…
ad3838f 
…ateMenu.tsx
@jvega190
[6633] Remove PreviewInPageInstancesPanel.tsx, update Changelog
7596eca
@jvega190
[6633] Remove logical resource from ViewVersionDialogContainer
abb624f
@jvega190
[6633] Remove logical resource from CompareVersionsDialog
688ff84
@jvega190
Merge branch 'develop' of https://github.com/craftercms/studio-ui int…
afb1c94 
…o enhancement/6633

# Conflicts:
#	ui/app/src/CHANGELOG.md
@jvega190
[6633] Remove logical resource from ToolsPanel
66fe83f
@jvega190
[6633] Add suspense to components
f5b358d
@jvega190 jvega190 marked this pull request as ready for review May 22, 2024 21:43
@jvega190 jvega190 requested a review from rart as a code owner May 22, 2024 21:43
rart
rart requested changes May 24, 2024
View reviewed changes
Copy link
Member

@rart rart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the useLogicResource and associated code too. Add to changelog

@jvega190
Copy link
Member Author

@rart added back PreviewInPageInstancesPanel as it is being used by the PreviewComponentsPanel

@jvega190 jvega190 requested a review from rart May 29, 2024 21:58
rart
rart requested changes May 31, 2024
View reviewed changes
ui/app/src/CHANGELOG.md Outdated Show resolved Hide resolved
@rart
Copy link
Member

rart commented Jun 4, 2024

@jvega190 bump. this has pending changes.

@jvega190 jvega190 requested a review from rart June 4, 2024 22:54
rart
rart reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@rart rart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There's a ComponentResource Interface on PreviewBrowseComponentsPanelUI which is not in use. Try to find other resource-related things like this that might have also slipped by.

rart
rart requested changes Jun 21, 2024
View reviewed changes
ui/app/src/components/ChangeContentTypeDialog/ChangeContentTypeDialogContainer.tsx Outdated Show resolved Hide resolved
ui/app/src/components/ChangeContentTypeDialog/ChangeContentTypeDialogContainer.tsx Outdated Show resolved Hide resolved
ui/app/src/components/ChangeContentTypeDialog/ChangeContentTypeDialogContainer.tsx Outdated Show resolved Hide resolved
ui/app/src/components/CompareVersionsDialog/CompareVersionsDialogContainer.tsx Outdated Show resolved Hide resolved
ui/app/src/components/DeleteContentTypeDialog/DeleteContentTypeDialogContainer.tsx Outdated Show resolved Hide resolved
ui/app/src/components/NewContentDialog/NewContentDialogContainer.tsx Outdated Show resolved Hide resolved
ui/app/src/components/NewContentDialog/NewContentDialogContainer.tsx Outdated Show resolved Hide resolved
ui/app/src/components/PreviewInPageInstancesPanel/PreviewInPageInstancesPanel.tsx Outdated Show resolved Hide resolved
ui/app/src/components/PreviewInPageInstancesPanel/index.ts Outdated Show resolved Hide resolved
ui/app/src/components/ToolsPanel/ToolsPanel.tsx Show resolved Hide resolved
@jvega190
Copy link
Member Author

  • There's a ComponentResource Interface on PreviewBrowseComponentsPanelUI which is not in use. Try to find other resource-related things like this that might have also slipped by.

Should I get rid of this signature too? https://github.com/craftercms/studio-ui/blob/develop/ui/app/src/components/StoreProvider/StoreProvider.tsx#L26

@jvega190 jvega190 requested a review from rart June 21, 2024 21:13
@rart
Copy link
Member

rart commented Jun 28, 2024

  • There's a ComponentResource Interface on PreviewBrowseComponentsPanelUI which is not in use. Try to find other resource-related things like this that might have also slipped by.

Should I get rid of this signature too? https://github.com/craftercms/studio-ui/blob/develop/ui/app/src/components/StoreProvider/StoreProvider.tsx#L26

Yes. Why wouldn't we?

@rart
Copy link
Member

rart commented Jun 28, 2024

Pls fix conflicts.

@jvega190
Copy link
Member Author

@rart there were still a couple of resource-related things I removed, I'll re-request review

@jvega190 jvega190 requested a review from rart June 28, 2024 20:34
@rart rart marked this pull request as draft July 8, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rart rart Awaiting requested review from rart rart is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jvega190 @rart