[7032] Uploading an image or file with invalid filename using Image Uploaded to S3 Repository or File Uploaded to S3 Repository datasources a window will show up that can't be closed or cancelled #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ploaded to S3 Repository or File Uploaded to S3 Repository datasources a window will show up that can't be closed or cancelled
jvega190
commented
Jul 17, 2024
| me.uploadingFile = false; | ||
| $('#uploadCancelButton').attr('disabled', false); | ||
|
|
||
| CStudioAuthoring.Operations.showSimpleDialog( |
There was a problem hiding this comment.
Since the SingleFileUpload component already does the error handling (shows an alert w/retry icon) this error dialog is no longer needed. The error was that the response was different so the parsing was failing and the state wasn't restored.
rart
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
craftercms/craftercms#7032