-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish APIs #3544
base: feature/6766
Are you sure you want to change the base?
Publish APIs #3544
Conversation
Initial publish updates
Regular publish package builder
Regular publishing package submission
* Add Studio API 1 to OAS file #5981 * Update API 1 endpoints missing .json * Fix typo in write-content API in OAS file * [develop] Update examples for write-content API #6798
…publish root becomes publish-all
notifySubmitter: | ||
type: boolean | ||
description: notify the submitter when request is approved/rejected | ||
publishAll: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this trump the PublishPackageRequest
? Feels a bit off. Let's discuss this a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PublishPackageRequest
params are not required. Notice that PublishPackageRequest params are flattened in this request body, it can be as simple as:
{
"siteId": "ed1",
"publishingTarget": "live",
"publishAll": true
}
or contain the list of paths
{
"siteId": "ed1",
"publishingTarget": "live",
"paths": [
{
"path": "/site/website/articles/",
"includeChildren": true,
"includeSoftDeps": true
}
]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume combining the two results will make PublishAll win?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, publish all flag will take precedence
…g when it is not a publish API request (craftercms#3590)
…uplicate insertion on SyncFromRepositoryTask (craftercms#3594)
…f there are other packages affecting the item
…em states update methods
…e other packages affecting the item
craftercms/craftercms#6766
Publish APIs
craftercms/craftercms#6398