Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish APIs #3544

Open
wants to merge 167 commits into
base: feature/6766
Choose a base branch
from
Open

Publish APIs #3544

wants to merge 167 commits into from

Conversation

jmendeza
Copy link
Member

@jmendeza jmendeza commented May 8, 2024

@jmendeza jmendeza requested a review from sumerjabri as a code owner May 8, 2024 19:37
@jmendeza jmendeza mentioned this pull request May 8, 2024
notifySubmitter:
type: boolean
description: notify the submitter when request is approved/rejected
publishAll:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this trump the PublishPackageRequest? Feels a bit off. Let's discuss this a bit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PublishPackageRequest params are not required. Notice that PublishPackageRequest params are flattened in this request body, it can be as simple as:

{
    "siteId": "ed1",
    "publishingTarget": "live",
    "publishAll": true
}

or contain the list of paths

{
    "siteId": "ed1",
    "publishingTarget": "live",
    "paths": [
        {
            "path": "/site/website/articles/",
            "includeChildren": true,
            "includeSoftDeps": true
        }
    ]
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume combining the two results will make PublishAll win?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, publish all flag will take precedence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants