Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The std::vector argument to addMetaEvent should be const. #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dewhisna
Copy link

The version of the addMetaEvent function that takes the metaData as a std::vector type should accept that std::vector argument as a const type. Otherwise, callers of this function that pass data from constant member functions and/or retrieve their data from constant getter functions have to either do a const_cast or declare their own types mutable and/or add temporary variables of a non-const type when they shouldn't need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant