Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Toshiba Remote Control B #2094

Merged
merged 9 commits into from
Jul 25, 2024
Merged

Add support of Toshiba Remote Control B #2094

merged 9 commits into from
Jul 25, 2024

Conversation

jackysze
Copy link
Contributor

@jackysze jackysze commented May 13, 2024

Re-creation of the accidentally permanently closed PR, incorporated comments from @NiKiZe

The third byte in the raw state array originally represents payload length only. It was found that the first 4 bits is being used to identify whether current remote control is A or B. #2089

  1. Modify the struct to accommodate both payload length and remote control type.
  2. Add constants and functions to set/get current remote control type.
  3. Fix the getInternalStateLength function to extract the last 4-bits instead using 8-bits.

Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@crankyoldgit crankyoldgit self-assigned this Jul 25, 2024
@crankyoldgit crankyoldgit merged commit c00a919 into crankyoldgit:master Jul 25, 2024
42 checks passed
@jackysze jackysze deleted the feature/toshiba-remote-b branch July 25, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants