Avoid forced heap escaping for polynomial commitment #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
commented
Dec 13, 2022
This was referenced Dec 13, 2022
|
PR looks good to me, removing the |
jsign
force-pushed
the
jsign/multiplefr
branch
from
fcc1cb4 to
74b088b
Compare
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
force-pushed
the
jsign/multiplefr
branch
from
74b088b to
008b094
Compare
|
@kevaundray, this is ready for review (or merge really). I've tested the impact of removing this, and despite isn't zero I think we can live with it. So, we can have the benefit of one less "custom" change to generated code for the future when we try to reorganize ourselves. |
kevaundray
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids a forced heap allocation since it avoids returning a pointer from a stack variable. This was noticed while looking at profiling information in
go-verkle.It also removes an unnecessary assignment.
Linked to ethereum/go-verkle#314