chore: Java interop PR #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Jan 23, 2024
kevaundray
commented
Jan 24, 2024
Comment on lines
+11
to
+30
| func TestJavaRegressionOneEndian(t *testing.T) { | ||
| hexStr := "f6e31f7a565a390b48fdd24569ac10d43562d19de37ea951c7f9f250a339d059" | ||
| byteArray := hexStrToBytes(hexStr) | ||
| _scalar, err := common.ReadScalar(bytes.NewReader(byteArray)) | ||
|
|
||
| if err == nil { | ||
| t.Fatalf("expected an error because the scalar is too large") | ||
| } | ||
| _ = _scalar | ||
| } | ||
| func TestJavaRegressionOtherEndian(t *testing.T) { | ||
| hexStr := "f6e31f7a565a390b48fdd24569ac10d43562d19de37ea951c7f9f250a339d059" | ||
| byteArray := hexStrToBytes(hexStr) | ||
| reverse(byteArray) | ||
| _scalar, err := common.ReadScalar(bytes.NewReader(byteArray)) | ||
| if err == nil { | ||
| t.Fatalf("expected an error because the scalar is too large, even though we changed the endian") | ||
| } | ||
| _ = _scalar | ||
| } |
There was a problem hiding this comment.
These are the failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will not be merged.
It serves to show that the java impl was not checking that the scalar was canonical and also to add interop tests