-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use orjson
to improve JSON marshalling performance
#691
base: main
Are you sure you want to change the base?
Conversation
orjson
to improve JSON marshalling performanceorjson
to improve JSON marshalling performance
2a43b26
to
c92e27b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again. Thanks for the quick review. I've just added a few thoughts about the consequences of removing the traditional CrateJsonEncoder
.
5b8b18c
to
402cdde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Do we have a benchmark? |
It's not a benchmark, but @widmogrod shared a flamegraph before/after over at #689 (comment). |
c779801
to
dd81035
Compare
About
Using orjson for JSON marshalling can yield performance wins. It has been used in CrateDB Toolkit already, in that case its sister library orjsonl. Thanks, @widmogrod.
References
Downstream
crate-2.0.0
, which usesorjson
for JSON marshalling crash#459crate-2.0.0
, which usesorjson
for JSON marshalling cratedb-toolkit#349crate-2.0.0
, which usesorjson
for JSON marshalling cratedb-examples#811crate-2.0.0
, which usesorjson
for JSON marshalling sqlalchemy-cratedb#195crate-2.0.0
, which usesorjson
for JSON marshalling langchain-cratedb#23crate-2.0.0
, which usesorjson
for JSON marshalling academy-fundamentals-course#49