Chore: Add software test about trailing slash on HTTP URL #33
Conversation
WalkthroughA new test function was added to verify that the Changes
Sequence Diagram(s)sequenceDiagram
participant Test as test_query_sql_trailing_slash
participant Main as cratedb_mcp.__main__
participant Query as query_sql
Test->>Main: Patch HTTP_URL to "http://localhost:4200/"
Test->>Query: Call query_sql("SELECT 42")
Query-->>Test: Return {"rows": [[42]]}
Test->>Test: Assert result is {"rows": [[42]]}
Possibly related PRs
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/test_mcp.py (1)
40-40: Consider adding a docstringAdding a brief docstring explaining why trailing slashes need special handling would improve maintainability and documentation.
def test_query_sql_trailing_slash(mocker): + """Verify that query_sql works correctly when HTTP_URL has a trailing slash.""" mocker.patch("cratedb_mcp.__main__.HTTP_URL", "http://localhost:4200/") assert query_sql("SELECT 42")["rows"] == [[42]]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/test_mcp.py(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
tests/test_mcp.py (1)
cratedb_mcp/__main__.py (1)
query_sql(31-34)
🔇 Additional comments (1)
tests/test_mcp.py (1)
40-43: Test looks good!This test is valuable as it helps verify the robustness of the
query_sqlfunction when dealing with trailing slashes in HTTP URLs. The use ofmocker.patchto inject a URL with a trailing slash is an effective approach to isolate this test case.
2 participants
cratedb-sqlparsefor implementing read-only mode #14