Skip to content

PIE download support & Downloader and ConfigValidator enhance #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazywhalecc merged 17 commits into from
Oct 21, 2025
Merged

PIE download support & Downloader and ConfigValidator enhance #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
25d7c72
use the upstream version
henderkes Oct 16, 2025
ccf262d
Update test workflow to trigger on pull request events only
crazywhalecc Oct 13, 2025
9ed77c1
use the spx upstream version (#931)
henderkes Oct 17, 2025
15638ce
Add log dir expose, unify SPC_FIX_DEPLOY_ROOT parsing
crazywhalecc Oct 17, 2025
b1abff6
don't use full install target, don't install-binaries
henderkes Oct 18, 2025
8ed68f4
don't pass unused envs
henderkes Oct 18, 2025
e281d26
Merge remote-tracking branch 'origin' into fix/frankenphp-readline
henderkes Oct 18, 2025
29c31d9
also only do that for macos (saves build time)
henderkes Oct 18, 2025
8923077
don't use full install target, don't install-binaries (#932)
henderkes Oct 18, 2025
605c06f
Add pie support for downloading sources
crazywhalecc Oct 20, 2025
e2fd3e1
Refactor ConfigValidator, make it more strict
crazywhalecc Oct 20, 2025
4e4ce28
Fix zip extract not strip dir bug
crazywhalecc Oct 20, 2025
49cfcbe
Update docs
crazywhalecc Oct 20, 2025
5e229a0
Update dependencies
crazywhalecc Oct 20, 2025
f8801e2
phpstan fix
crazywhalecc Oct 20, 2025
487980c
phpunit fix
crazywhalecc Oct 20, 2025
dd752cd
Fix windows 7z unzip strip function, fix windows pkg extract files path
crazywhalecc Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
name: Tests

on:
push:
branches:
- main
paths:
- 'src/globals/test-extensions.php'
pull_request:
branches: [ "main" ]
types: [ opened, synchronize, reopened ]
paths:
- 'src/**'
- 'config/**'
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ docker/source/
# default package root directory
/pkgroot/**

# Windows PHP SDK binary tools
/php-sdk-binary-tools/**

# default pack:lib and release directory
/dist/**
packlib_files.txt
Expand Down
1 change: 1 addition & 0 deletions bin/spc-alpine-docker
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/source:/app/source"
MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/dist:/app/dist"
MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/downloads:/app/downloads"
MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/pkgroot:/app/pkgroot"
MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/log:/app/log"
if [ -f "$(pwd)/craft.yml" ]; then
MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/craft.yml:/app/craft.yml"
fi
Expand Down
1 change: 1 addition & 0 deletions bin/spc-gnu-docker
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/source:/app/source"
MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/dist:/app/dist"
MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/downloads:/app/downloads"
MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/pkgroot:/app/pkgroot"
MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/log:/app/log"
if [ -f "$(pwd)/craft.yml" ]; then
MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/craft.yml:/app/craft.yml"
fi
Expand Down
Loading