crc qe virtualized migration #111
Conversation
WalkthroughA comprehensive Tekton pipeline catalog is introduced for CRC QE virtualized testing, spanning versions 0.1 through 0.9. Each version includes pipeline definitions, README documentation, and sample PipelineRun configurations across Fedora, RHEL, and Windows platforms. The pipeline orchestrates multi-stage workflows for infrastructure provisioning, QE test execution, result aggregation, and resource cleanup with conditional execution based on OS parameters. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant PR as PipelineRun
participant Correlate as Correlate
participant HostInfo as Host Info
participant Provision as Provision<br/>(Fedora/RHEL/Windows)
participant Install as Install CRC
participant QE as QE Tests
participant Sink as Datalake Sink
participant URLGen as URL Generator
participant Finally as Finally (Decommission)
User->>PR: Trigger PipelineRun
PR->>Correlate: Run correlate task
Correlate->>HostInfo: Pass workspace data
HostInfo->>Provision: Determine platform, pass params
Provision->>Install: Infrastructure ready
Install->>QE: CRC environment prepared
QE->>Sink: Test results ready
Sink->>URLGen: Results stored in S3
URLGen->>PR: Generate artifact URLs
PR->>Finally: Queue finalization
Finally->>Finally: Debug info (if enabled)
Finally->>Finally: Decommission resources<br/>(Fedora/RHEL/Windows)
Finally->>User: Pipeline complete
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~45 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 27
🧹 Nitpick comments (19)
catalog/pipelines/crc-qe-virtualized/0.1/README.md (1)
4-4: Fix hyphenation in descriptive text."Self provisioned" should use a hyphen to form a compound adjective.
-The target host will be self provisioned. +The target host will be self-provisioned.catalog/pipelines/crc-qe-virtualized/0.3/README.md (1)
4-4: Fix hyphenation in descriptive text.Same issue as 0.1: "self provisioned" should use a hyphen to form a compound adjective.
-The target host will be self-provisioned. +The target host will be self-provisioned.catalog/pipelines/crc-qe-virtualized/0.1/crc-qe-virtualized.yaml (2)
13-14: Fix typo in annotation."Virualization" should be "virtualization".
- tekton.dev/tags: openshift-local, qe, nested virualization + tekton.dev/tags: openshift-local, qe, nested virtualization
47-51: Fix typos in parameter descriptions.Lines 47 and 54 contain spelling errors: "ditributables" → "distributables" and "scnearios" → "scenarios".
- description: full base url to download ditributables and shasumsfiles - default: https://mirror.openshift.com/pub/openshift-v4/clients/crc/latest - - name: shasum-file - description: file name for shasum to check distributable - default: sha256sum.txt - # QE params - - name: e2e-tag - description: tags to select e2e scnearios. Default empty values which means all scnearios + description: full base url to download distributables and shasum files + default: https://mirror.openshift.com/pub/openshift-v4/clients/crc/latest + - name: shasum-file + description: file name for shasum to check distributable + default: sha256sum.txt + # QE params + - name: e2e-tag + description: tags to select e2e scenarios. Default empty values which means all scenarioscatalog/pipelines/crc-qe-virtualized/CHANGELOG.md (3)
19-19: Fix hyphenation and capitalization in changelog entries.Line 19 should use a hyphen for the compound modifier "pre-release", and line 24 should capitalize "Windows" as a proper noun (Microsoft product name).
-- Added task for sync internal assets to S3, to allow testing pre release versions within public providers +- Added task for sync internal assets to S3, to allow testing pre-release versions within public providers
24-24: Capitalize Windows operating system name."Windows" should be capitalized as a proper noun throughout.
-- Added windows 10 / 11 desktop as possible target. Windows target is on public cloud +- Added Windows 10 / 11 desktop as possible target. Windows target is on public cloud
29-29: Complete the placeholder changelog entry.The 0.2 entry contains "???", indicating incomplete or unknown changes. This should be filled in or removed if no substantive changes occurred between 0.1 and 0.2.
Please provide a description of changes in version 0.2 or clarify whether this entry can be removed.
catalog/pipelines/crc-qe-virtualized/0.3/crc-qe-virtualized.yaml (2)
13-13: Fix typo in annotation (same as 0.1)."Virualization" should be "virtualization".
- tekton.dev/tags: openshift-local, qe, nested virualization + tekton.dev/tags: openshift-local, qe, nested virtualization
58-65: Fix typos in parameter descriptions (same as 0.1).Lines 58 and 65 contain spelling errors: "ditributables" → "distributables" and "scnearios" → "scenarios".
- description: full base url to download ditributables and shasumsfiles + description: full base url to download distributables and shasum files default: https://mirror.openshift.com/pub/openshift-v4/clients/crc/latest - name: shasum-file description: file name for shasum to check distributable default: sha256sum.txt # QE params - name: e2e-tag - description: tags to select e2e scnearios. Default empty values which means all scnearios + description: tags to select e2e scenarios. Default empty values which means all scenarioscatalog/pipelines/crc-qe-virtualized/0.9/crc-qe-virtualized.yaml (1)
323-361: Consider passing debug parameter to provision-fedora for consistency.The debug parameter is passed to
provision-rhel(line 405) andprovision-windows(line 451), but not toprovision-fedora(lines 323-361). If debug functionality is needed in the Fedora provisioning task (as defined in the referenced mapt resolver), consider adding it for consistency with RHEL and Windows provisioning.Also applies to: 404-406, 450-452
catalog/pipelines/crc-qe-virtualized/0.6/README.md (1)
14-36: Clarify the duplicate task list and #REVIEW marker.Lines 15–22 list a set of basic tasks, followed by a
#REVIEWcomment on line 23, then lines 24–35 repeat and expand the task list. This structure is unclear—the#REVIEWmarker appears to be a placeholder or work-in-progress indicator rather than a functional comment. Please clarify:
- Is the first block (lines 15–22) outdated and should be removed?
- Is the
#REVIEWmarker intended as a flag for manual review before deployment?- Should documentation be updated to reflect the final, canonical task list?
catalog/pipelines/crc-qe-virtualized/0.5/README.md (1)
14-36: Clarify the duplicate task list and #REVIEW marker.Lines 15–22 list a set of basic tasks, followed by a
#REVIEWcomment on line 23, then lines 24–35 repeat and expand the task list. This structure is unclear—the#REVIEWmarker appears to be a placeholder or work-in-progress indicator rather than a functional comment. Please clarify:
- Is the first block (lines 15–22) outdated and should be removed?
- Is the
#REVIEWmarker intended as a flag for manual review before deployment?- Should documentation be updated to reflect the final, canonical task list?
catalog/pipelines/crc-qe-virtualized/0.6/samples/windows11-22h2-pro.yaml (1)
10-11: Remove trailing whitespace on line 11.The
windows-versionvalue has an unnecessary trailing space after'11'that should be removed for consistency.- - name: windows-version - value: '11' + - name: windows-version + value: '11'catalog/pipelines/crc-qe-virtualized/0.2/README.md (2)
8-8: Complete the Params documentation section.The Params section contains only "TBC" placeholder. Please document the expected parameters for this pipeline version.
Would you like me to generate a template for documenting the parameters based on the 0.2 pipeline definition and related samples?
35-35: Fix typo in task file reference.Line 35 references
url-generator.yamls(plural) but should beurl-generator.yaml(singular) to match Kubernetes resource naming convention.-oc apply -f catalog/task/url-generator/0.1/url-generator.yamls +oc apply -f catalog/task/url-generator/0.1/url-generator.yamlcatalog/pipelines/crc-qe-virtualized/0.3/samples/windows11-22h2-ent.yaml (1)
13-13: Remove trailing whitespace on line 13.The
windows-versionvalue has an unnecessary trailing space after'11'that should be removed for consistency.- - name: windows-version - value: '11' + - name: windows-version + value: '11'catalog/pipelines/crc-qe-virtualized/0.8/README.md (1)
4-4: Fix grammar: use hyphenation for "self-provisioned".Use a hyphen when joining the words "self" and "provisioned" to form a compound adjective.
-The target host will be self provisioned. +The target host will be self-provisioned.As per LanguageTool suggestions.
catalog/pipelines/crc-qe-virtualized/0.7/README.md (1)
4-4: Fix grammar: use hyphenation for "self-provisioned".Use a hyphen when joining the words "self" and "provisioned" to form a compound adjective.
-The target host will be self provisioned. +The target host will be self-provisioned.As per LanguageTool suggestions.
catalog/pipelines/crc-qe-virtualized/0.9/p_sort.yaml (1)
10-20: Note: Cluster metadata present in exported manifest.Lines 10–20 contain Kubernetes cluster metadata (
creationTimestamp,generation,resourceVersion,uid,namespace), indicating this file was exported from a running cluster in namespacedevtoolsqe--pipeline. While this doesn't affect functionality, consider whether these should be removed for the catalog distribution, as they reference a specific cluster state and may cause conflicts if reapplied to different clusters.Consider removing cluster-specific metadata before committing to the catalog:
- creationTimestamp: "2024-06-12T02:43:56Z" - generation: 41 - labels: - app.kubernetes.io/version: "0.9" - paas.redhat.com/appcode: OLQE-001 - redhat.com/phase: qe - redhat.com/product: openshift-local - name: crc-qe-virtualized - namespace: devtoolsqe--pipeline - resourceVersion: "1844930934" - uid: a1c74d87-98ee-48b0-a14d-73126a21767a + labels: + app.kubernetes.io/version: "0.9" + redhat.com/phase: qe + redhat.com/product: openshift-local + name: crc-qe-virtualized
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (60)
catalog/pipelines/crc-qe-virtualized/0.1/README.md(1 hunks)catalog/pipelines/crc-qe-virtualized/0.1/crc-qe-virtualized.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.1/samples/fedora.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.1/samples/rhel8.8.0-nightly.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.1/samples/rhel9.2.0-nightly.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.2/README.md(1 hunks)catalog/pipelines/crc-qe-virtualized/0.2/crc-qe-virtualized.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.2/samples/fedora.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.2/samples/rhel8.8.0-nightly.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.2/samples/rhel9.2.0-nightly.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.3/README.md(1 hunks)catalog/pipelines/crc-qe-virtualized/0.3/crc-qe-virtualized.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.3/samples/fedora.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.3/samples/rhel8.8.0-nightly.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.3/samples/rhel9.2.0-nightly.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.3/samples/windows11-22h2-ent.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.3/samples/windows11-22h2-pro.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.4/README.md(1 hunks)catalog/pipelines/crc-qe-virtualized/0.4/crc-qe-virtualized.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.4/samples/fedora.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.4/samples/rhel8.8.0-nightly.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.4/samples/rhel9.2.0-nightly.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.4/samples/windows11-22h2-ent-pre-release.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.4/samples/windows11-22h2-ent.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.4/samples/windows11-22h2-pro.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.5/README.md(1 hunks)catalog/pipelines/crc-qe-virtualized/0.5/crc-qe-virtualized.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.5/samples/fedora.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.5/samples/rhel8.8.0-nightly.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.5/samples/rhel9.2.0-nightly.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.5/samples/windows11-22h2-ent-pre-release.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.5/samples/windows11-22h2-ent.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.5/samples/windows11-22h2-pro.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.6/README.md(1 hunks)catalog/pipelines/crc-qe-virtualized/0.6/crc-qe-virtualized.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.6/samples/fedora.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.6/samples/rhel.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.6/samples/windows11-22h2-ent-pre-release.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.6/samples/windows11-22h2-ent.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.6/samples/windows11-22h2-pro.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.7/README.md(1 hunks)catalog/pipelines/crc-qe-virtualized/0.7/crc-qe-virtualized.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.7/samples/fedora.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.7/samples/rhel.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.7/samples/windows11-22h2-ent-pre-release.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.7/samples/windows11-22h2-ent.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.7/samples/windows11-22h2-pro.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.8/README.md(1 hunks)catalog/pipelines/crc-qe-virtualized/0.8/crc-qe-virtualized.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.8/samples/fedora.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.8/samples/rhel-arm64.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.8/samples/rhel-x86.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.8/samples/windows11-22h2-ent-pre-release.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.8/samples/windows11-22h2-ent.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.8/samples/windows11-22h2-pro.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.9/crc-qe-virtualized.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.9/lp_sort.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.9/p.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/0.9/p_sort.yaml(1 hunks)catalog/pipelines/crc-qe-virtualized/CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 Gitleaks (8.28.0)
catalog/pipelines/crc-qe-virtualized/0.9/p_sort.yaml
[high] 798-806: Possible Kubernetes Secret detected, posing a risk of leaking credentials/tokens from your deployments
(kubernetes-secret-yaml)
catalog/pipelines/crc-qe-virtualized/0.6/crc-qe-virtualized.yaml
[high] 69-76: Possible Kubernetes Secret detected, posing a risk of leaking credentials/tokens from your deployments
(kubernetes-secret-yaml)
catalog/pipelines/crc-qe-virtualized/0.8/crc-qe-virtualized.yaml
[high] 70-77: Possible Kubernetes Secret detected, posing a risk of leaking credentials/tokens from your deployments
(kubernetes-secret-yaml)
catalog/pipelines/crc-qe-virtualized/0.9/lp_sort.yaml
[high] 741-749: Possible Kubernetes Secret detected, posing a risk of leaking credentials/tokens from your deployments
(kubernetes-secret-yaml)
catalog/pipelines/crc-qe-virtualized/0.9/crc-qe-virtualized.yaml
[high] 70-77: Possible Kubernetes Secret detected, posing a risk of leaking credentials/tokens from your deployments
(kubernetes-secret-yaml)
catalog/pipelines/crc-qe-virtualized/0.7/crc-qe-virtualized.yaml
[high] 70-77: Possible Kubernetes Secret detected, posing a risk of leaking credentials/tokens from your deployments
(kubernetes-secret-yaml)
catalog/pipelines/crc-qe-virtualized/0.9/p.yaml
[high] 798-806: Possible Kubernetes Secret detected, posing a risk of leaking credentials/tokens from your deployments
(kubernetes-secret-yaml)
🪛 LanguageTool
catalog/pipelines/crc-qe-virtualized/0.4/README.md
[grammar] ~4-~4: Use a hyphen to join words.
Context: ...ion of crc. The target host will be self provisioned. ## Params TBC ## Requi...
(QB_NEW_EN_HYPHEN)
catalog/pipelines/crc-qe-virtualized/0.6/README.md
[grammar] ~4-~4: Use a hyphen to join words.
Context: ...ion of crc. The target host will be self provisioned. ## Params TBC ## Requi...
(QB_NEW_EN_HYPHEN)
catalog/pipelines/crc-qe-virtualized/CHANGELOG.md
[grammar] ~19-~19: Use a hyphen to join words.
Context: ...ernal assets to S3, to allow testing pre release versions within public providers...
(QB_NEW_EN_HYPHEN)
[uncategorized] ~24-~24: “Windows” (operating system by Microsoft) is a proper noun and needs to be capitalized.
Context: ...ernal vs internal) ## [0.3] - Added windows 10 / 11 desktop as possible target. Win...
(A_WINDOWS)
catalog/pipelines/crc-qe-virtualized/0.3/README.md
[grammar] ~4-~4: Use a hyphen to join words.
Context: ...ion of crc. The target host will be self provisioned. ## Params TBC ## Requi...
(QB_NEW_EN_HYPHEN)
catalog/pipelines/crc-qe-virtualized/0.8/README.md
[grammar] ~4-~4: Use a hyphen to join words.
Context: ...ion of crc. The target host will be self provisioned. ## Params TBC ## Requi...
(QB_NEW_EN_HYPHEN)
catalog/pipelines/crc-qe-virtualized/0.7/README.md
[grammar] ~4-~4: Use a hyphen to join words.
Context: ...ion of crc. The target host will be self provisioned. ## Params TBC ## Requi...
(QB_NEW_EN_HYPHEN)
catalog/pipelines/crc-qe-virtualized/0.2/README.md
[grammar] ~4-~4: Use a hyphen to join words.
Context: ...ion of crc. The target host will be self provisioned. ## Params TBC ## Requi...
(QB_NEW_EN_HYPHEN)
catalog/pipelines/crc-qe-virtualized/0.1/README.md
[grammar] ~4-~4: Use a hyphen to join words.
Context: ...ion of crc. The target host will be self provisioned. ## Params TBC ## Requi...
(QB_NEW_EN_HYPHEN)
catalog/pipelines/crc-qe-virtualized/0.5/README.md
[grammar] ~4-~4: Use a hyphen to join words.
Context: ...ion of crc. The target host will be self provisioned. ## Params TBC ## Requi...
(QB_NEW_EN_HYPHEN)
🪛 YAMLlint (1.37.1)
catalog/pipelines/crc-qe-virtualized/0.7/crc-qe-virtualized.yaml
[warning] 316-316: too many spaces after colon
(colons)
[error] 542-542: syntax error: mapping values are not allowed here
(syntax)
🔇 Additional comments (53)
catalog/pipelines/crc-qe-virtualized/0.1/samples/rhel8.8.0-nightly.yaml (1)
1-28: LGTM.The RHEL 8.8.0 sample PipelineRun is well-formed and consistent with the pipeline structure. Parameter alignment with other RHEL versions is flagged in the rhel9.2.0 review.
catalog/pipelines/crc-qe-virtualized/0.3/samples/windows11-22h2-pro.yaml (1)
1-26: LGTM.The Windows 11 22H2 Pro sample PipelineRun is well-formed and aligns with the 0.3 pipeline definition structure.
catalog/pipelines/crc-qe-virtualized/0.1/samples/rhel9.2.0-nightly.yaml (1)
1-28: The review comment contains a factual error regarding theimage-idparameter.The original review comment claims "rhel8.8.0 sample includes parameter 'image-id' (not present in rhel9.2.0)," but
image-iddoes not exist in either file. The actual parameter differences between the samples are:
- rhel9.2.0 includes
rh-account-secret: credentials-rh-subs-crcqe-prod(absent in rhel8.8.0)- rhel8.8.0 includes
run-integration: "false"(absent in rhel9.2.0)These differences may be intentional due to distinct requirements between RHEL versions. Verify the pipeline definition accepts these parameters as optional or check if version-specific parameter sets are expected before flagging as inconsistency.
Likely an incorrect or invalid review comment.
catalog/pipelines/crc-qe-virtualized/0.3/crc-qe-virtualized.yaml (1)
128-149: Verify the design rationale for divergent task naming patterns.The inconsistency is confirmed: Fedora and Windows use generic
infra-managementandinfra-management-windowstaskRef names with anoperationparameter (create/destroy), while RHEL uses distinctinfra-rhel-provisionandinfra-rhel-decommissiontaskRef names. This creates a mixed pattern—some provisioning tasks are parameter-driven while others are name-driven. Either clarify why this design choice exists or standardize the approach across all three platforms.catalog/pipelines/crc-qe-virtualized/0.9/crc-qe-virtualized.yaml (2)
645-676: Debug-info task should only run on specific OS when debug=true.The
debug-infotask currently only checks for RHEL version and debug=true (lines 647-652), meaning it runs only when both conditions are met. This is likely intentional but verify that debug info is also needed for Fedora and Windows OS platforms when debug=true.
70-77: Static analysis flag is a false positive on Kubernetes Secret documentation.The gitleaks warning about a Kubernetes Secret at lines 70-77 is a false positive. This section contains a template/documentation example showing the expected format for Azure credentials secrets, not an actual secret being committed. This is appropriate documentation for users configuring the workspace.
catalog/pipelines/crc-qe-virtualized/0.8/samples/fedora.yaml (1)
1-22: Sample PipelineRun for Fedora 0.8 looks good.The sample correctly references the crc-qe-virtualized pipeline with appropriate parameters and workspace bindings.
catalog/pipelines/crc-qe-virtualized/0.1/samples/fedora.yaml (1)
1-22: Sample PipelineRun for Fedora 0.1 looks good.The baseline sample is appropriate for the 0.1 version with a minimal set of parameters and workspaces compared to later versions.
catalog/pipelines/crc-qe-virtualized/0.5/samples/windows11-22h2-pro.yaml (1)
10-15: Verify target-platform parameter exists in 0.5 pipeline definition.The sample passes a
target-platformparameter (line 10) that is not present in the 0.9 pipeline definition. Confirm this parameter was part of the 0.5 pipeline specification.catalog/pipelines/crc-qe-virtualized/0.3/samples/fedora.yaml (1)
1-22: Sample PipelineRun for Fedora 0.3 looks good.The sample correctly references the crc-qe-virtualized pipeline with standard parameters and workspace binding.
catalog/pipelines/crc-qe-virtualized/0.8/samples/rhel-arm64.yaml (1)
1-38: Sample PipelineRun for RHEL arm64 0.8 looks good.The sample properly configures RHEL 9.3 with appropriate workspaces for cloud credentials, RHEL subscription, and reporting.
catalog/pipelines/crc-qe-virtualized/0.4/samples/fedora.yaml (1)
1-22: Sample PipelineRun for Fedora 0.4 looks good.The sample follows the established pattern with standard parameters and workspace binding.
catalog/pipelines/crc-qe-virtualized/0.7/samples/windows11-22h2-ent.yaml (1)
1-33: Sample PipelineRun for Windows 11 0.7 looks good.The sample properly configures Windows 11 Enterprise with appropriate Azure credentials workspace binding.
catalog/pipelines/crc-qe-virtualized/0.6/samples/rhel.yaml (1)
1-43: LGTM!The PipelineRun sample is properly structured and follows the Tekton schema. Parameter bindings and workspace configurations are appropriate for the RHEL 9.3 test environment.
catalog/pipelines/crc-qe-virtualized/0.8/samples/windows11-22h2-ent-pre-release.yaml (1)
1-43: LGTM!The Windows 11 pre-release PipelineRun sample is well-structured with appropriate Windows-specific parameters and credential management.
catalog/pipelines/crc-qe-virtualized/0.4/README.md (1)
23-36: Clarify intent of duplicate task listings.Lines 24-35 appear to duplicate tasks already listed in lines 15-22, marked with a
#REVIEWcomment. Confirm whether these duplicate entries should be removed or if they represent an intentional list of alternative/complementary tasks.catalog/pipelines/crc-qe-virtualized/0.5/samples/rhel8.8.0-nightly.yaml (1)
1-30: LGTM!The RHEL 8.8.0 nightly PipelineRun sample is properly configured with correct repository URLs and appropriate parameter settings.
catalog/pipelines/crc-qe-virtualized/0.5/samples/windows11-22h2-ent.yaml (1)
1-26: LGTM!The Windows 11 22H2 Enterprise sample is well-structured with appropriate parameters for production release testing.
catalog/pipelines/crc-qe-virtualized/0.5/samples/windows11-22h2-ent-pre-release.yaml (1)
1-36: LGTM!The Windows 11 22H2 Enterprise pre-release sample is properly configured with internal asset URLs and appropriate test parameters.
catalog/pipelines/crc-qe-virtualized/0.2/samples/rhel9.2.0-nightly.yaml (1)
1-30: LGTM!The RHEL 9.2.0 nightly PipelineRun sample is properly structured with correct repository URLs and subscription credentials.
catalog/pipelines/crc-qe-virtualized/0.7/samples/windows11-22h2-ent-pre-release.yaml (1)
1-43: LGTM!The Windows 11 22H2 Enterprise pre-release sample for 0.7 is well-structured with comprehensive credential management through multiple workspace bindings.
catalog/pipelines/crc-qe-virtualized/0.6/samples/windows11-22h2-ent.yaml (1)
1-24: LGTM: PipelineRun manifest structure looks good.The Windows 11 22H2 ENT sample is correctly structured with valid Tekton v1beta1 API, appropriate parameter bindings, workspace configuration for credentials and data sharing, and consistent timeout settings.
If this sample requires a
target-platform: windowsparameter as shown in the PR description, please verify that this parameter is present in the pipeline definition (catalog/pipelines/crc-qe-virtualized/0.6/crc-qe-virtualized.yaml) and consider adding it here for explicitness.catalog/pipelines/crc-qe-virtualized/0.3/samples/rhel9.2.0-nightly.yaml (1)
1-30: LGTM: RHEL 9.2.0 nightly sample is well-structured.The PipelineRun manifest is syntactically correct and provides appropriate parameters for RHEL 9.2.0 nightly provisioning.
However, note that this sample configures only
pipelines-dataworkspace, whereas later versions (e.g., 0.6) include credential workspaces (az-credentials,aws-credentials,reportportal-credentials). Verify that this workspace configuration is intentional for the 0.3 pipeline, or if credential workspaces should be added for consistency across versions.catalog/pipelines/crc-qe-virtualized/0.6/samples/fedora.yaml (1)
1-35: LGTM: Fedora 0.6 sample is well-structured.The PipelineRun manifest is syntactically correct with proper parameter bindings for Fedora 39 QE provisioning and comprehensive workspace configuration for credentials and shared data.
catalog/pipelines/crc-qe-virtualized/0.6/samples/windows11-22h2-ent-pre-release.yaml (1)
1-43: LGTM: Windows 11 22H2 ENT pre-release sample is well-structured.The PipelineRun manifest is syntactically correct with extended parameters for pre-release testing (
windows-vmsize,e2e-tag,run-integration) and comprehensive workspace configuration.catalog/pipelines/crc-qe-virtualized/0.3/samples/rhel8.8.0-nightly.yaml (1)
1-30: LGTM: RHEL 8.8.0 nightly sample is well-structured.The PipelineRun manifest is syntactically correct and provides appropriate parameters for RHEL 8.8.0 nightly provisioning.
Note: This sample (version 0.3) configures only
pipelines-dataworkspace, whereas later versions (e.g., 0.6) include credential workspaces. Verify this is intentional for 0.3, or align with newer workspace configurations if needed.catalog/pipelines/crc-qe-virtualized/0.4/samples/rhel8.8.0-nightly.yaml (1)
1-30: LGTM: RHEL 8.8.0 nightly sample (0.4) is well-structured.The PipelineRun manifest is syntactically correct with appropriate parameters.
Note: This 0.4 sample is identical to the 0.3 version and maintains minimal workspace configuration (only
pipelines-data), whereas later versions (e.g., 0.6) include credential workspaces. Consider whether version progression should include workspace updates or if minimal config is intentional for 0.3/0.4.catalog/pipelines/crc-qe-virtualized/0.7/samples/rhel.yaml (1)
1-38: LGTM!This PipelineRun sample follows the established pattern with proper parameterization for RHEL 9.3, complete workspace and secret bindings, and appropriate timeout configuration.
catalog/pipelines/crc-qe-virtualized/0.5/samples/fedora.yaml (1)
1-22: LGTM!The sample is well-formed with appropriate Fedora-specific parameters and workspace configuration for this version.
catalog/pipelines/crc-qe-virtualized/0.8/samples/rhel-x86.yaml (1)
1-38: LGTM!Properly configured PipelineRun with consistent parameter and workspace setup. The rhel-x86 naming aligns with the architecture-specific sample organization in version 0.8.
catalog/pipelines/crc-qe-virtualized/0.5/samples/rhel9.2.0-nightly.yaml (1)
18-19: Verify parameter usage pattern for rh-account-secret.The
rh-account-secretparameter is being passed as a plain value rather than referenced as a workspace secret. Verify that the referenced 0.5 crc-qe-virtualized pipeline expects this as a parameter (not a workspace), as later versions (0.6+) bind similar credentials as secret workspaces instead.catalog/pipelines/crc-qe-virtualized/0.2/README.md (1)
33-33: Standardize task path structure.Line 33 uses a different path structure (
orchestrator/catalog/task/...) compared to all other task paths (catalog/task/...). Verify this is intentional; if not, align it with the standard path convention.-oc apply -f orchestrator/catalog/task/crc-qe-cli/0.1/crc-qe-cli.yaml +oc apply -f catalog/task/crc-qe-cli/0.1/crc-qe-cli.yamlcatalog/pipelines/crc-qe-virtualized/0.2/samples/fedora.yaml (1)
1-22: LGTM!The sample is well-formed with appropriate Fedora-specific parameters and workspace configuration for version 0.2.
catalog/pipelines/crc-qe-virtualized/0.7/samples/fedora.yaml (1)
1-35: Good structure for fedora sample.This PipelineRun sample follows the expected Tekton pattern. The parameters, workspaces, and timeout configuration align with the pipeline orchestration model.
catalog/pipelines/crc-qe-virtualized/0.8/README.md (1)
23-35: Clarify intent of #REVIEW marker and duplicate task list.Line 23 contains a
#REVIEWcomment followed by a duplicate and extended task list (lines 24–35). Clarify whether this section is incomplete documentation or intentional duplication. If the extended list supersedes the earlier one (lines 15–22), consider consolidating or removing the redundant entries.catalog/pipelines/crc-qe-virtualized/0.7/samples/windows11-22h2-pro.yaml (1)
1-33: Good Windows 22H2 Pro sample structure.The PipelineRun properly configures Windows deployment parameters, including the correct cloud-credentials secret for Azure (az-crcqe-bot).
catalog/pipelines/crc-qe-virtualized/0.4/samples/windows11-22h2-ent.yaml (1)
1-26: Verify workspace bindings are intentionally minimal for 0.4.This sample only binds the
pipelines-dataworkspace, whereas the 0.7windows11-22h2-pro.yamlalso includescloud-credentials,ocp-pullsecret, andreportportal-credentials. Confirm whether this is an intentional difference in the 0.4 API or an omission.catalog/pipelines/crc-qe-virtualized/0.4/samples/windows11-22h2-ent-pre-release.yaml (1)
1-36: Good pre-release sample with appropriate VM sizing and staging URLs.The pre-release sample correctly includes the
windows-vmsizeparameter for test infrastructure scaling and references internal staging URLs (2.20.0-1) instead of public release URLs. QE parameters (e2e-tag,run-integration) are appropriately configured.catalog/pipelines/crc-qe-virtualized/0.4/samples/windows11-22h2-pro.yaml (1)
1-26: Good structure consistent with other 0.4 Windows samples.The 0.4 Windows Pro sample follows the established pattern. Workspace bindings are consistent with the 0.4 series (pipelines-data only).
catalog/pipelines/crc-qe-virtualized/0.7/README.md (1)
23-35: Clarify intent of #REVIEW marker and duplicate task list.Line 23 contains a
#REVIEWcomment followed by a duplicate and extended task list (lines 24–35). Clarify whether this section is incomplete documentation or intentional duplication. If the extended list supersedes the earlier one (lines 15–22), consider consolidating or removing the redundant entries.catalog/pipelines/crc-qe-virtualized/0.2/samples/rhel8.8.0-nightly.yaml (1)
1-30: LGTM!This PipelineRun sample is well-structured and follows Tekton conventions. The parameterization is appropriate for a nightly RHEL 8.8.0 build configuration.
catalog/pipelines/crc-qe-virtualized/0.4/samples/rhel9.2.0-nightly.yaml (1)
1-30: LGTM!This PipelineRun sample for RHEL 9.2.0 is well-structured and appropriately configured with RHEL-specific parameters like
rh-account-secretfor subscription management.catalog/pipelines/crc-qe-virtualized/0.8/samples/windows11-22h2-pro.yaml (1)
1-33: LGTM!This Windows 11 22H2 Pro PipelineRun sample is well-configured with appropriate workspace and secret bindings for Windows-specific cloud infrastructure and ReportPortal integration.
catalog/pipelines/crc-qe-virtualized/0.8/samples/windows11-22h2-ent.yaml (1)
1-33: LGTM!This Windows 11 22H2 ENT PipelineRun sample is consistent with the Pro variant and correctly specifies the enterprise feature pack. Workspace and secret configuration is appropriate.
catalog/pipelines/crc-qe-virtualized/0.9/lp_sort.yaml (2)
42-48: ✓ Debug flag logic is correct in 0.9.This version properly implements the debug flag behavior:
debug-infotask runs only whendebug='true'(lines 42–48) — shows credentials for troubleshootingdecomission-rhelruns only whendebug='false'(lines 110–112) — cleans up resourcesThis is a significant improvement over versions 0.6 and 0.7, which hardcoded the debug value and created contradictions with the decommission logic. The PR objective of "fixes related with debug flag and decommission" is properly realized here.
Also applies to: 110-112
385-405: Good evolution to git resolver for infrastructure tasks.The provision and decommission tasks now use git resolver instead of bundle resolver, pointing to the
redhat-developer/maptrepository at specific versions (v0.8.0). This approach:
- Improves reproducibility with explicit revision pinning
- Decouples from bundle maintainers
- Allows easier task updates by changing the git revision
Consistent use of git resolver across all infrastructure provisioning tasks is cleaner than the mixed approach in earlier versions.
Also applies to: 423-460, 472-515
catalog/pipelines/crc-qe-virtualized/0.9/p_sort.yaml (2)
1-1: ✓ Stable Tekton API version (v1) with proper structure.This pipeline uses the stable
tekton.dev/v1API (notv1beta1), indicating maturity. The pipeline structure is comprehensive with:
- Explicit parameter types and defaults (lines 189–274)
- Defined results for e2e and integration test URLs (lines 275–281)
- Clear task orchestration with proper dependency management
- Conditional execution via when clauses for multi-platform support
Also applies to: 22-22, 275-281
42-58: ✓ Debug flag and decommission logic is properly implemented.The debug parameter handling is correct:
- Lines 42–58:
debug-infotask runs only whendebug='true'— exposes credentials for troubleshooting- Lines 117–125:
decomission-rhelruns only whendebug='false'— cleans up resourcesThis aligns with the PR objective of fixing the "debug flag (verbosity and decommission)" logic that was contradictory in earlier versions.
Also applies to: 117-125
catalog/pipelines/crc-qe-virtualized/0.9/p.yaml (2)
798-806: Placeholder Kubernetes Secret in documentation (not a real secret).Lines 798–806 define an example Kubernetes Secret with placeholder values (XXX, XXXX). This is documentation, not a real secret, so the Gitleaks warning is a false positive. Suppress or annotate if needed for CI/CD scanning.
50-58: The review comment is factually incorrect.Upon inspection, both when-clause
valuesfields and parameter defaults consistently use''''''(six single quotes) throughout the file—not the mismatch claimed. Line 190-272 parameter defaults show the samedefault: ''''''pattern as the when-clause values. There is no inconsistency between empty-value representations in when-clauses versus parameter defaults.One minor exception exists at line 226 (
default: ""), but this is unrelated to the claimed issue. The review's assertion that "parameter defaults use''(two single quotes)" is unfounded.Likely an incorrect or invalid review comment.
catalog/pipelines/crc-qe-virtualized/0.5/crc-qe-virtualized.yaml (1)
113-115: Debug flag handling is correctly integrated in 0.5.The debug parameter, debug-info task, and decomission-rhel logic are properly aligned:
- Parameter default is
'false'(line 115)- When-clause checks match this format (line 456-461:
['']for empty, line 524-525:["false"]for false)- Decommission tasks are conditional: only run RHEL cleanup when debug is false (preserving resources for troubleshooting when debug=true)
Also applies to: 455-461, 523-525
catalog/pipelines/crc-qe-virtualized/0.8/crc-qe-virtualized.yaml (2)
178-180: Debug flag handling is correctly integrated in 0.8.The debug parameter and when-clause values are internally consistent:
- Parameter default is
'false'(line 180)- When-clause check at line 626 uses
["''"]format, which aligns with the parameter default format (line 110+)- Decommission logic correctly skips RHEL cleanup when debug=true (preserving resources for troubleshooting)
Also applies to: 623-629, 686-688
70-77: Example Kubernetes Secret in workspace documentation (not a real secret).Lines 70–77 define an example Secret with placeholder values (XXX, XXXX, etc.). This is documentation, not a real secret, so the Gitleaks warning is a false positive.
| - name: qe-worspace-subpath | ||
| description: subpath on workspace where storing ephemeral qe results | ||
| default: qe-results |
There was a problem hiding this comment.
Resolve parameter naming inconsistency.
Line 56 defines a parameter named qe-worspace-subpath (typo: "worspace" instead of "workspace"), but line 224 references worspace-qe-subpath (different name order, same typo). These must match. Standardize to either qe-workspace-subpath or workspace-qe-subpath (with correct spelling) and update all references.
- name: qe-worspace-subpath
- description: subpath on workspace where storing ephemeral qe results
+ description: subpath on workspace where storing ephemeral QE results
default: qe-results
...
- name: worspace-qe-subpath
+ value: $(params.qe-workspace-subpath)
- value: $(params.qe-worspace-subpath)Also applies to: 224-226
🤖 Prompt for AI Agents
In catalog/pipelines/crc-qe-virtualized/0.1/crc-qe-virtualized.yaml around lines
56 and 224-226, the parameter name is inconsistent and misspelled as
`qe-worspace-subpath` and `worspace-qe-subpath`; rename it to a single
consistent correct identifier (e.g., `qe-workspace-subpath`) and update every
declaration and reference in the file to that exact name, keeping the same
default value (`qe-results`) and adjusting any usages or templates that
reference the old misspelled variants.
| #REVIEW | ||
| oc apply -f catalog/task/gather-run-info/0.1/gather-run-info.yaml | ||
| oc apply -f catalog/task/gather-host-info/0.1/gather-host-info.yaml | ||
| oc apply -f catalog/task/gather-crc-info/0.1/gather-crc-info.yaml | ||
| oc apply -f catalog/task/gather-s3-info/0.1/gather-s3-info.yaml | ||
| oc apply -f catalog/task/asset-checker-http/0.1/asset-checker-http.yaml | ||
| oc apply -f catalog/task/crc-preparer/0.2/crc-preparer.yaml | ||
| oc apply -f catalog/task/crc-builder-tray/0.3/crc-builder-tray-mac-universal.yaml | ||
| oc apply -f catalog/task/crc-builder-tray/0.3/crc-builder-tray-x64.yaml | ||
| oc apply -f catalog/task/crc-builder-installer/0.3/crc-builder-installer.yaml | ||
| oc apply -f orchestrator/catalog/task/crc-qe-cli/0.1/crc-qe-cli.yaml | ||
| oc apply -f catalog/task/s3-sink-workspace/0.3/s3-sink-workspace.yaml | ||
| oc apply -f catalog/task/url-generator/0.1/url-generator.yamls |
There was a problem hiding this comment.
Resolve incomplete documentation and task list duplication.
The "#REVIEW" marker (line 23) indicates incomplete review. Additionally, the task list contains apparent duplicates (gather-run-info, gather-crc-info, and crc-preparer appear in both lines 15–22 and 24–27), and line 35 has a typo: "url-generator.yamls" should be "url-generator.yaml". Please clarify the intended task list and remove the marker before merge.
-oc apply -f catalog/task/gather-run-info/0.1/gather-run-info.yaml
-oc apply -f catalog/task/gather-crc-info/0.1/gather-crc-info.yaml
-oc apply -f catalog/task/crc-preparer/0.2/crc-preparer.yaml
-oc apply -f catalog/task/crc-qe-cli/0.1/crc-qe-cli.yaml
-oc apply -f catalog/task/infra-fedora-provision/0.1/infra-fedora-provision.yaml
-oc apply -f catalog/task/infra-fedora-decommission/0.1/infra-fedora-decommission.yaml
-oc apply -f catalog/task/infra-rhel-provision/0.1/infra-rhel-provision.yaml
-oc apply -f catalog/task/infra-rhel-decommission/0.1/infra-rhel-decommission.yaml
-#REVIEW
-oc apply -f catalog/task/gather-run-info/0.1/gather-run-info.yaml
-oc apply -f catalog/task/gather-host-info/0.1/gather-host-info.yaml
-oc apply -f catalog/task/gather-crc-info/0.1/gather-crc-info.yaml
-oc apply -f catalog/task/gather-s3-info/0.1/gather-s3-info.yaml
-oc apply -f catalog/task/asset-checker-http/0.1/asset-checker-http.yaml
-oc apply -f catalog/task/crc-preparer/0.2/crc-preparer.yaml
-oc apply -f catalog/task/crc-builder-tray/0.3/crc-builder-tray-mac-universal.yaml
-oc apply -f catalog/task/crc-builder-tray/0.3/crc-builder-tray-x64.yaml
-oc apply -f catalog/task/crc-builder-installer/0.3/crc-builder-installer.yaml
-oc apply -f orchestrator/catalog/task/crc-qe-cli/0.1/crc-qe-cli.yaml
-oc apply -f catalog/task/s3-sink-workspace/0.3/s3-sink-workspace.yaml
-oc apply -f catalog/task/url-generator/0.1/url-generator.yamls
+oc apply -f catalog/task/gather-run-info/0.1/gather-run-info.yaml
+oc apply -f catalog/task/gather-host-info/0.1/gather-host-info.yaml
+oc apply -f catalog/task/gather-crc-info/0.1/gather-crc-info.yaml
+oc apply -f catalog/task/gather-s3-info/0.1/gather-s3-info.yaml
+oc apply -f catalog/task/asset-checker-http/0.1/asset-checker-http.yaml
+oc apply -f catalog/task/crc-preparer/0.2/crc-preparer.yaml
+oc apply -f catalog/task/crc-builder-tray/0.3/crc-builder-tray-mac-universal.yaml
+oc apply -f catalog/task/crc-builder-tray/0.3/crc-builder-tray-x64.yaml
+oc apply -f catalog/task/crc-builder-installer/0.3/crc-builder-installer.yaml
+oc apply -f orchestrator/catalog/task/crc-qe-cli/0.1/crc-qe-cli.yaml
+oc apply -f catalog/task/s3-sink-workspace/0.3/s3-sink-workspace.yaml
+oc apply -f catalog/task/url-generator/0.1/url-generator.yamlCommittable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In catalog/pipelines/crc-qe-virtualized/0.1/README.md around lines 23 to 35,
remove the "#REVIEW" marker and clean up duplicated oc apply lines so each task
(e.g., gather-run-info, gather-host-info, gather-crc-info, gather-s3-info,
asset-checker-http, crc-preparer, crc-builder-tray variants,
crc-builder-installer, crc-qe-cli, s3-sink-workspace, url-generator) appears
exactly once; also fix the typo on line 35 by changing "url-generator.yamls" to
"url-generator.yaml" and ensure the final list is the authoritative,
non-duplicated set before merging.
| annotations: | ||
| tekton.dev/pipelines.minVersion: "0.24.x" | ||
| tekton.dev/categories: qe | ||
| tekton.dev/tags: openshift-local, qe, nested virualization |
There was a problem hiding this comment.
Fix typo: "virualization" → "virtualization".
The annotation contains a misspelled word that should be corrected for documentation accuracy.
- tekton.dev/tags: openshift-local, qe, nested virualization
+ tekton.dev/tags: openshift-local, qe, nested virtualization📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| tekton.dev/tags: openshift-local, qe, nested virualization | |
| tekton.dev/tags: openshift-local, qe, nested virtualization |
🤖 Prompt for AI Agents
In catalog/pipelines/crc-qe-virtualized/0.2/crc-qe-virtualized.yaml at line 13,
the tekton.dev/tags annotation contains a typo "virualization"; update that tag
to the correct spelling "virtualization" so the annotation reads:
tekton.dev/tags: openshift-local, qe, nested virtualization.
| - name: asset-name | ||
| value: e2e-non-ux.xml | ||
| finally: | ||
| - name: decomission-fedora |
There was a problem hiding this comment.
Fix critical task name spelling: "decomission" → "decommission".
The finally block task is misspelled decomission-fedora; it should be decommission-fedora. This likely causes the task reference lookup to fail if the actual task resource is spelled correctly (with "decommission").
- - name: decomission-fedora
+ - name: decommission-fedoraVerify that the referenced task infra-management is called with the correct project name (crc-qe-virtualized-fedora-...) for proper cleanup.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: decomission-fedora | |
| - name: decommission-fedora |
🤖 Prompt for AI Agents
In catalog/pipelines/crc-qe-virtualized/0.2/crc-qe-virtualized.yaml around line
282, the finally task name is misspelled as "decomission-fedora" — change it to
"decommission-fedora" to match the actual task resource name; also verify the
referenced task `infra-management` invocation uses the correct project name
pattern (crc-qe-virtualized-fedora-...) and update the params/metadata for that
task call if necessary so cleanup targets the correct project.
| - name: pipelines-data | ||
| workspace: pipelines-data | ||
| timeout: "15m" | ||
| - name: decomission-rhel |
There was a problem hiding this comment.
Fix critical task name spelling: "decomission" → "decommission".
The finally block task is misspelled decomission-rhel; it should be decommission-rhel. This likely causes the task reference lookup to fail if the actual task resource is spelled correctly.
- - name: decomission-rhel
+ - name: decommission-rhel📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: decomission-rhel | |
| - name: decommission-rhel |
🤖 Prompt for AI Agents
In catalog/pipelines/crc-qe-virtualized/0.2/crc-qe-virtualized.yaml around line
302, the finally block references the task name "decomission-rhel" which is
misspelled; change it to "decommission-rhel" so it matches the actual task
resource name and avoids lookup failures.
| oc apply -f catalog/task/crc-builder-installer/0.3/crc-builder-installer.yaml | ||
| oc apply -f orchestrator/catalog/task/crc-qe-cli/0.1/crc-qe-cli.yaml | ||
| oc apply -f catalog/task/s3-sink-workspace/0.3/s3-sink-workspace.yaml | ||
| oc apply -f catalog/task/url-generator/0.1/url-generator.yamls |
There was a problem hiding this comment.
Fix typo in file extension.
The task YAML file should use singular .yaml, not plural .yamls.
-oc apply -f catalog/task/url-generator/0.1/url-generator.yamls
+oc apply -f catalog/task/url-generator/0.1/url-generator.yaml📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| oc apply -f catalog/task/url-generator/0.1/url-generator.yamls | |
| oc apply -f catalog/task/url-generator/0.1/url-generator.yaml |
🤖 Prompt for AI Agents
In catalog/pipelines/crc-qe-virtualized/0.8/README.md around line 35, the
kubectl/oc command references the incorrect file extension
"url-generator.yamls"; change the filename to use the singular ".yaml" extension
(url-generator.yaml) so the command reads "oc apply -f
catalog/task/url-generator/0.1/url-generator.yaml".
|
|
||
| # Rhel related params | ||
| - name: rhel-version | ||
| description: Major.Minor RHEL version (i.e 9.3, 9.2, 9,1...) |
There was a problem hiding this comment.
Fix typos in parameter descriptions.
Several parameter descriptions contain spelling errors:
- Line 123: "9,1" should be "9.1"
- Line 143: "ditributables" should be "distributables"; "shasumsfiles" should be "shasum files"
- Line 154: "scnearios" should be "scenarios"
- name: rhel-version
description: Major.Minor RHEL version (i.e 9.3, 9.2, 9.1...) - name: downloadable-url
description: full base url to download distributables and shasum files - name: e2e-tag
description: tags to select e2e scenarios. Default empty values which means all scenariosAlso applies to: 143-143, 154-154
🤖 Prompt for AI Agents
In catalog/pipelines/crc-qe-virtualized/0.9/crc-qe-virtualized.yaml around lines
123, 143 and 154, fix the typos in the parameter descriptions: on line 123
change "9,1" to "9.1"; on line 143 change "ditributables" to "distributables"
and "shasumsfiles" to "shasum files"; on line 154 change "scnearios" to
"scenarios". Ensure punctuation and spacing remain consistent after the
replacements.
| - name: e2e-tag | ||
| description: tags to select e2e scnearios. Default empty values which means all scnearios | ||
| default: "''" | ||
| - name: qe-worspace-subpath |
There was a problem hiding this comment.
Fix typo in parameter name: "worspace" → "workspace".
The parameter name contains a consistent typo: qe-worspace-subpath should be qe-workspace-subpath. This typo is repeated throughout the pipeline at the definition (line 156) and multiple usage sites (lines 571, 612, 629, 640).
- - name: qe-worspace-subpath
+ - name: qe-workspace-subpath
description: subpath on workspace where storing ephemeral qe results
default: qe-resultsUpdate all references to match this corrected name across the pipeline (lines 571, 612, 629, 640).
Also applies to: 571-571, 612-612, 629-629, 640-640
🤖 Prompt for AI Agents
In catalog/pipelines/crc-qe-virtualized/0.9/crc-qe-virtualized.yaml around line
156 (and usages at lines 571, 612, 629, 640) the parameter name has a typo
"qe-worspace-subpath" — rename the parameter to "qe-workspace-subpath" at its
definition (line 156) and update every reference at lines 571, 612, 629, and 640
to use the corrected name so all definitions and usages match exactly.
| workspaces: | ||
| - name: pipelines-data | ||
| workspace: pipelines-data | ||
| - name: decomission-fedora |
There was a problem hiding this comment.
Fix spelling of decommission tasks (currently "decomission").
Task names use the incorrect spelling "decomission" instead of "decommission". This should be corrected for consistency and clarity.
- - name: decomission-fedora
+ - name: decommission-fedora- - name: decomission-rhel
+ - name: decommission-rhel- - name: decomission-windows
+ - name: decommission-windowsAlso applies to: 708-708, 741-741
🤖 Prompt for AI Agents
In catalog/pipelines/crc-qe-virtualized/0.9/crc-qe-virtualized.yaml around lines
677, 708, and 741 the task name is misspelled as "decomission-..." — update each
occurrence to the correct spelling "decommission-..." so all task names
consistently use "decommission" (search for any other occurrences of
"decomission" in the file and replace them as well).
| steps: | ||
| - computeResources: {} | ||
| image: registry.access.redhat.com/ubi9/ubi-minimal | ||
| name: show-denug-info |
There was a problem hiding this comment.
Fix typo in task step name: "denug" → "debug".
The step name contains a typo that could appear in logs and confuse users during debugging.
- name: show-denug-info
+ name: show-debug-infoAlso applies to: 38-38
🤖 Prompt for AI Agents
In catalog/pipelines/crc-qe-virtualized/0.9/p.yaml around line 38, the task step
name is misspelled as "show-denug-info"; update the name to "show-debug-info" to
correct the typo so logs and UIs show the proper "debug" wording, and verify any
references to this step name elsewhere in the pipeline manifest are updated to
match.
|
@albfan Hi, we don't need to migrate the old version pipelines. Only the current pipeline is enough. |
| runAfter: | ||
| - host-info | ||
| taskRef: | ||
| name: gather-s3-info |
There was a problem hiding this comment.
Pipeline migration to git means we no longer use the task. We can use git resolver or define the task within the pipeline, like the host-info task.
2 participants
Added some minor fixes related with debug flag (verbosity and decommission)
Summary by CodeRabbit
Release Notes
New Features
Documentation