Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate url name for changelist_actions #111

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

predatell
Copy link

For me "Dupe name is fine. https://code.djangoproject.com/ticket/14259" is not working. When I click on the button/link from change list in admin function does not run

@@ -150,7 +150,7 @@ def _get_action_urls(self):
)
),
# Dupe name is fine. https://code.djangoproject.com/ticket/14259
Copy link
Author

@predatell predatell Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work in Django 2.0 and Django 2.1

@crccheck
Copy link
Owner

Can you describe how to replicate the problem? And does it only happen in certain versions of Django? The code looks fine, but I don't quite understand the circumstances where this happens, and I haven't checked the git history for why the "Dupe name is fine" comment is there.

@predatell
Copy link
Author

I have already described how to replicate it: "When I click on the button/link from change list in admin function does not run".
I have added action to changelist_actions. Then I tried to run this action from CHANGE LIST in admin. And it does not work! So change_actions works but changelist_actions do NOT work! I have tested it in Django 2.2, 3.0, 3.1

@predatell
Copy link
Author

Actions from changelist_actions need unique url names

@crccheck
Copy link
Owner

what was the name? and can you add a test case to this PR? It'll really speed up how long it'll take to get this merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants