fix:updated the package.json file #1456
Conversation
Signed-off-by: shitrerohit <[email protected]>
WalkthroughUpdated package metadata in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
package.json (2)
5-5: Prefer structured author/maintainers metadata.Use an object and/or add a maintainers/contributors list for org ownership clarity.
Apply if desired:
- "author": "LFDT", + "author": { "name": "LFDT" }, + "maintainers": [ + { "name": "LFDT Team", "email": "<[email protected]>" } + ],
1-7: Avoid accidental npm publish if this is not a public package.If this repo isn’t meant to be published, mark it private.
{ "name": "api-gateway", + "private": true, "version": "2.1.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (1)
package.json (1)
3-3: Version bump looks fine; ensure release hygiene (tag + changelog).If this drives publishing/CI, add a CHANGELOG entry for 2.1.0 and create/rely on a v2.1.0 tag so downstream artifacts remain traceable.
| "author": "", | ||
| "license": "MIT", | ||
| "author": "LFDT", | ||
| "license": "Apache-2.0", |
There was a problem hiding this comment.
🧩 Analysis chain
License switch to Apache-2.0 requires repo-wide compliance updates.
Confirm legal sign‑off, update LICENSE to Apache‑2.0, add/refresh NOTICE, and scrub MIT mentions (README badges, headers). Check other packages in the repo aren’t still declaring MIT.
Run to verify:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "1) LICENSE presence and content"
test -f LICENSE && rg -n "Apache License, Version 2\.0" LICENSE || echo "LICENSE missing or not Apache-2.0"
echo -e "\n2) NOTICE presence (Apache recommends)"
test -f NOTICE || echo "NOTICE missing"
echo -e "\n3) Residual MIT references (excluding build artifacts)"
rg -nI -S '\bMIT\b' -g '!**/node_modules/**' -g '!**/dist/**' -g '!**/build/**' || true
echo -e "\n4) package.json files still declaring MIT"
fd -t f package.json | xargs -I{} rg -n '"license"\s*:\s*"MIT"' {} || trueLength of output: 405
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "1) LICENSE presence and content"
if [ -f LICENSE ]; then
rg -n "Apache License, Version 2.0" LICENSE || grep -n "Apache License, Version 2.0" LICENSE || echo "LICENSE present but Apache-2.0 string not found"
else
echo "LICENSE missing"
fi
echo -e "\n2) NOTICE presence (Apache recommends)"
test -f NOTICE || echo "NOTICE missing"
echo -e "\n3) Residual MIT references (fallback to grep, excluding common build dirs)"
grep -RIn --binary-files=without-match --exclude-dir=node_modules --exclude-dir=dist --exclude-dir=build --exclude-dir=.git -E '\bMIT\b' . || echo "no MIT matches found"
echo -e "\n4) package.json files still declaring MIT"
find . -type f -name package.json -not -path "./node_modules/*" -not -path "./dist/*" -not -path "./build/*" -print0 | \
while IFS= read -r -d '' file; do
printf "\n== %s ==\n" "$file"
grep -nE '"license"[[:space:]]*:[[:space:]]*"MIT"' "$file" || true
doneLength of output: 384
Add NOTICE and obtain legal sign‑off — LICENSE already Apache‑2.0
- LICENSE verified to contain "Apache License, Version 2.0" (found in LICENSE).
- NOTICE file missing — add a root NOTICE with required attributions.
- No residual "MIT" occurrences found; checked package.json files: ./package.json, ./libs/aws/package.json, ./libs/common/package.json (none declare MIT).
- Obtain and record legal sign‑off (corporate approval / CLA/DCO) before merging.
🤖 Prompt for AI Agents
In package.json around line 6, the project already uses "Apache-2.0" but is
missing the required root NOTICE file and needs legal sign‑off; add a NOTICE
file at the repository root containing the required Apache 2.0 attribution
statements and any third‑party notices used by the project, ensure the
package.json license fields remain "Apache-2.0" (and update any other metadata
if necessary), and obtain and record corporate legal approval (CLA/DCO or
equivalent) before merging.
Signed-off-by: Krishna Waske <[email protected]>
|
What?
Updated the package.json file with correct details
Summary by CodeRabbit
Documentation
Chores