Skip to content

Conversation

@GHkrishna
Copy link
Contributor

@GHkrishna GHkrishna commented Sep 25, 2025

What

Summary by CodeRabbit

  • Chores
    • Updated Docker build configuration across services to include the pnpm workspace configuration, enabling consistent workspace-aware dependency installation during image builds.
    • No runtime or feature behavior changes; improves build reliability and consistency across services.

@coderabbitai
Copy link

coderabbitai bot commented Sep 25, 2025

Walkthrough

Copies pnpm-workspace.yaml into multiple service Dockerfiles’ build stages alongside package.json to make workspace configuration available during dependency installation. No other build steps or runtime logic are modified.

Changes

Cohort / File(s) Summary
Docker build workspace config update
Dockerfiles/Dockerfile.agent-provisioning, Dockerfiles/Dockerfile.agent-service, Dockerfiles/Dockerfile.api-gateway, Dockerfiles/Dockerfile.cloud-wallet, Dockerfiles/Dockerfile.connection, Dockerfiles/Dockerfile.geolocation, Dockerfiles/Dockerfile.issuance, Dockerfiles/Dockerfile.ledger, Dockerfiles/Dockerfile.notification, Dockerfiles/Dockerfile.organization, Dockerfiles/Dockerfile.seed, Dockerfiles/Dockerfile.user, Dockerfiles/Dockerfile.utility, Dockerfiles/Dockerfile.verification, Dockerfiles/Dockerfile.webhook
Added COPY of pnpm-workspace.yaml into build stage to enable pnpm workspace configuration during dependency installation; no other changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

Thump-thump goes my build-time beat,
I tuck a workspace in, neat and discreet.
Docker burrows, layers align,
pnpm sniffs the vine—so fine!
Carrot-shaped commits, crisp and bright,
Ship the image—hop into the night. 🥕🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly indicates the primary purpose of the changeset, namely fixing Docker build failures caused by issues with pnpm catalog configuration, and it aligns with the described additions of the pnpm-workspace.yaml across Dockerfiles. It succinctly summarizes the root cause addressed without extraneous detail, making it easy for teammates to understand the main intent at a glance. The phrasing is concise and directly tied to the actual modifications in the PR.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/dockerfile-build

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e2a29b and e22fa41.

📒 Files selected for processing (15)
  • Dockerfiles/Dockerfile.agent-provisioning (1 hunks)
  • Dockerfiles/Dockerfile.agent-service (1 hunks)
  • Dockerfiles/Dockerfile.api-gateway (1 hunks)
  • Dockerfiles/Dockerfile.cloud-wallet (1 hunks)
  • Dockerfiles/Dockerfile.connection (1 hunks)
  • Dockerfiles/Dockerfile.geolocation (1 hunks)
  • Dockerfiles/Dockerfile.issuance (1 hunks)
  • Dockerfiles/Dockerfile.ledger (1 hunks)
  • Dockerfiles/Dockerfile.notification (1 hunks)
  • Dockerfiles/Dockerfile.organization (1 hunks)
  • Dockerfiles/Dockerfile.seed (1 hunks)
  • Dockerfiles/Dockerfile.user (1 hunks)
  • Dockerfiles/Dockerfile.utility (1 hunks)
  • Dockerfiles/Dockerfile.verification (1 hunks)
  • Dockerfiles/Dockerfile.webhook (1 hunks)
🔇 Additional comments (15)
Dockerfiles/Dockerfile.ledger (1)

10-12: Workspace manifest now available during install

Adding pnpm-workspace.yaml alongside package.json ensures the build stage respects the workspace layout during pnpm i, which should resolve the catalog misses we saw earlier.

Dockerfiles/Dockerfile.connection (1)

10-12: Consistent workspace-aware setup

Mirroring the pnpm-workspace.yaml copy here keeps the connection service build in sync with the rest of the workspace-aware images. Looks good.

Dockerfiles/Dockerfile.webhook (1)

10-12: Workspace manifest copied before install

This should unblock pnpm i for the webhook image by giving it visibility into the monorepo layout. Nice catch.

Dockerfiles/Dockerfile.utility (1)

11-13: Utility build now has workspace context

Copying pnpm-workspace.yaml here aligns the utility Docker build with the rest of the services and keeps pnpm installs deterministic.

Dockerfiles/Dockerfile.notification (1)

10-12: Notification image gains workspace awareness

Good to see the workspace manifest included before the install step; this should fix the catalog lookup failures.

Dockerfiles/Dockerfile.verification (1)

10-12: Verification build picks up pnpm workspace

Copying the workspace file here keeps dependency resolution aligned with the monorepo setup. All good.

Dockerfiles/Dockerfile.agent-provisioning (1)

21-23: Agent-provisioning build unblocked

Including pnpm-workspace.yaml before pnpm i should resolve the missing catalog issue for this image as well. Thanks for keeping it consistent.

Dockerfiles/Dockerfile.agent-service (1)

18-18: Keeping pnpm-workspace.yaml in the build context is exactly what we needed.

This ensures pnpm resolves workspace packages correctly during the install step. Nicely done.

Dockerfiles/Dockerfile.issuance (1)

11-11: Workspace manifest copy looks good.

Having pnpm-workspace.yaml available before pnpm i will keep the workspace-aware install working in Docker builds.

Dockerfiles/Dockerfile.organization (1)

11-11: Solid addition for pnpm workspace awareness.

This mirrors the fix across the other services and unblocks dependency installs inside the container build.

Dockerfiles/Dockerfile.user (1)

13-13: Nice catch on copying pnpm-workspace.yaml.

With this in place the pnpm install layer will see the workspace metadata and resolve catalog packages correctly.

Dockerfiles/Dockerfile.seed (1)

16-16: Good to ensure the workspace file is explicitly present.

This keeps the seed image consistent with the other services for workspace-aware pnpm installs.

Dockerfiles/Dockerfile.cloud-wallet (1)

12-12: Workspace manifest inclusion looks correct.

This aligns the build stage with pnpm’s expectations so the workspace dependencies resolve cleanly.

Dockerfiles/Dockerfile.api-gateway (1)

11-11: Copying pnpm-workspace.yaml here is the right move.

It ensures the pnpm install step has the workspace metadata it needs inside the container build context.

Dockerfiles/Dockerfile.geolocation (1)

11-11: Workspace manifest copy is spot on.

This keeps the geo-location build consistent with the other services and fixes the pnpm workspace resolution issue.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@GHkrishna GHkrishna self-assigned this Sep 25, 2025
@GHkrishna GHkrishna added the bug Something isn't working label Sep 25, 2025
@sonarqubecloud
Copy link

@GHkrishna GHkrishna merged commit 72bfb3e into main Sep 25, 2025
8 checks passed
@GHkrishna GHkrishna deleted the fix/dockerfile-build branch September 25, 2025 13:48
ankita-p17 pushed a commit that referenced this pull request Sep 30, 2025
Signed-off-by: Krishna Waske <[email protected]>
Signed-off-by: Ankita Patidar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants