Fixed code analysis issues

credfeto · Nov 15, 2023 · bc5bf12 · bc5bf12
1 parent 2f33043
commit bc5bf12
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/Credfeto.ChangeLog.Tests/AssemblySettings.cs b/src/Credfeto.ChangeLog.Tests/AssemblySettings.cs
@@ -1,3 +1,7 @@
 using System.Diagnostics.CodeAnalysis;
 
+[assembly:
+    SuppressMessage(category: "Philips.CodeAnalysis.MaintainabilityAnalyzers",
+                    checkId: "PH2140: Avoid ExcludeFromCodeCoverage",
+                    Justification = "This is a unit test assembly - no need for coverage of the test code itself")]
 [assembly: ExcludeFromCodeCoverage]
diff --git a/src/Credfeto.ChangeLog/ChangeLogReader.cs b/src/Credfeto.ChangeLog/ChangeLogReader.cs
@@ -128,6 +128,9 @@ private static bool IsMatchingVersion(Version? version, string line)
             return StringComparer.InvariantCultureIgnoreCase.Equals(x: line, y: Constants.UnreleasedHeader);
         }
 
+        return Candidates(version)
+            .Any(candidate => line.StartsWith(value: candidate, comparisonType: StringComparison.OrdinalIgnoreCase));
+
         static IEnumerable<string> Candidates(Version expected)
         {
             int build = expected.Build is 0 or -1
@@ -141,8 +144,5 @@ static IEnumerable<string> Candidates(Version expected)
                 yield return $"## [{expected.Major}.{expected.Minor}]";
             }
         }
-
-        return Candidates(version)
-            .Any(candidate => line.StartsWith(value: candidate, comparisonType: StringComparison.OrdinalIgnoreCase));
     }
 }