Skip to content

Commit

Permalink
Bump org.testcontainers:testcontainers from 1.17.6 to 1.18.0 (#268)
Browse files Browse the repository at this point in the history
* Bump org.testcontainers:testcontainers from 1.17.6 to 1.18.0

Bumps [org.testcontainers:testcontainers](https://github.com/testcontainers/testcontainers-java) from 1.17.6 to 1.18.0.
- [Release notes](https://github.com/testcontainers/testcontainers-java/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-java@1.17.6...1.18.0)

---
updated-dependencies:
- dependency-name: org.testcontainers:testcontainers
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Use module name now that com.github.docker-java:docker-java-api:3.3.0 defines an automatic module name in its manifest.

* Fix test

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Big Andy <[email protected]>
  • Loading branch information
dependabot[bot] and big-andy-coates authored Apr 21, 2023
1 parent 9f8c371 commit 0899664
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: CodeQL

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]

Expand All @@ -9,7 +11,7 @@ permissions:

jobs:
analyze:
name: Analyze
if: ${{ github.run_number != 1 }}
runs-on: ubuntu-latest
permissions:
actions: read
Expand Down
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ subprojects {

extra.apply {
set("creekVersion", "0.4.1")
set("testContainersVersion", "1.17.6") // https://mvnrepository.com/artifact/org.testcontainers/testcontainers
set("testContainersVersion", "1.18.0") // https://mvnrepository.com/artifact/org.testcontainers/testcontainers
set("spotBugsVersion", "4.7.3") // https://mvnrepository.com/artifact/com.github.spotbugs/spotbugs-annotations
set("jacksonVersion", "2.14.2") // https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-annotations
set("picocliVersion", "4.7.3") // https://mvnrepository.com/artifact/info.picocli/picocli
Expand Down
2 changes: 1 addition & 1 deletion executor/src/main/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
requires java.management;
requires com.github.spotbugs.annotations;
requires testcontainers;
requires docker.java.api;
requires com.github.dockerjava.api;
requires com.fasterxml.jackson.databind;
requires com.fasterxml.jackson.dataformat.xml;
requires com.fasterxml.jackson.datatype.jdk8;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,7 @@ void shouldThrowOnUnknownDockerImage() {
e.getMessage(),
startsWith(
"Failed to start service: test-service-0, image: i-do-not-exist:latest"));
assertThat(e.getCause().getMessage(), containsString("Container startup failed"));

assertThat(e.getCause().getCause().getMessage(), containsString("Can't get Docker image"));
assertThat(e.getCause().getMessage(), containsString("Can't get Docker image"));
}

@Test
Expand Down

0 comments on commit 0899664

Please sign in to comment.