Skip to content

Commit

Permalink
Bump com.google.guava:guava-testlib from 33.0.0-jre to 33.2.1-jre (#461)
Browse files Browse the repository at this point in the history
* Bump com.google.guava:guava-testlib from 33.0.0-jre to 33.2.1-jre

Bumps [com.google.guava:guava-testlib](https://github.com/google/guava) from 33.0.0-jre to 33.2.1-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava-testlib
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix weird issue with annotation in test compilation

Without this change `./gradlew :executor:compileTestJava` fails with:

```
> Task :executor:compileTestJava
/home/runner/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/33.2.1-jre/818e780da2c66c63bbb6480fef1f3855eeafa3e4/guava-33.2.1-jre.jar(/com/google/common/collect/Streams.class): warning: Cannot find annotation method 'replacement()' in type 'InlineMe': class file for com.google.errorprone.annotations.InlineMe not found
/home/runner/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/33.2.1-jre/818e780da2c66c63bbb6480fef1f3855eeafa3e4/guava-33.2.1-jre.jar(/com/google/common/collect/Streams.class): warning: Cannot find annotation method 'replacement()' in type 'InlineMe'
/home/runner/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/33.2.1-jre/818e780da2c66c63bbb6480fef1f3855eeafa3e4/guava-33.2.1-jre.jar(/com/google/common/collect/Streams.class): warning: Cannot find annotation method 'value()' in type 'InlineMeValidationDisabled': class file for com.google.errorprone.annotations.InlineMeValidationDisabled not found
/home/runner/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/33.2.1-jre/818e780da2c66c63bbb6480fef1f3855eeafa3e4/guava-33.2.1-jre.jar(/com/google/common/collect/Streams.class): warning: Cannot find annotation method 'replacement()' in type 'InlineMe'
/home/runner/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/33.2.1-jre/818e780da2c66c63bbb6480fef1f3855eeafa3e4/guava-33.2.1-jre.jar(/com/google/common/collect/Streams.class): warning: Cannot find annotation method 'value()' in type 'InlineMeValidationDisabled'
/home/runner/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/33.2.1-jre/818e780da2c66c63bbb6480fef1f3855eeafa3e4/guava-33.2.1-jre.jar(/com/google/common/collect/Streams.class): warning: Cannot find annotation method 'replacement()' in type 'InlineMe'
/home/runner/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/33.2.1-jre/818e780da2c66c63bbb6480fef1f3855eeafa3e4/guava-33.2.1-jre.jar(/com/google/common/collect/Streams.class): warning: Cannot find annotation method 'value()' in type 'InlineMeValidationDisabled'
/home/runner/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/33.2.1-jre/818e780da2c66c63bbb6480fef1f3855eeafa3e4/guava-33.2.1-jre.jar(/com/google/common/collect/Streams.class): warning: Cannot find annotation method 'replacement()' in type 'InlineMe'
/home/runner/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/33.2.1-jre/818e780da2c66c63bbb6480fef1f3855eeafa3e4/guava-33.2.1-jre.jar(/com/google/common/collect/Streams.class): warning: Cannot find annotation method 'value()' in type 'InlineMeValidationDisabled'
error: warnings found and -Werror specified
```

`./gradlew allDeps` should the correct annotations dependency being part of the test compilation classpath.

Go figure.

* Switch to adding module

see: https://github.com/google/error-prone/releases/tag/v2.26.1

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Big Andy <[email protected]>
  • Loading branch information
dependabot[bot] and big-andy-coates authored Jun 23, 2024
1 parent b6c8c12 commit 9c884a9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ subprojects {
set("log4jVersion", "2.23.1") // https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-core
set("slf4jVersion", "2.0.13") // https://mvnrepository.com/artifact/org.slf4j/slf4j-api

set("guavaVersion", "33.0.0-jre") // https://mvnrepository.com/artifact/com.google.guava/guava
set("guavaVersion", "33.2.1-jre") // https://mvnrepository.com/artifact/com.google.guava/guava
set("junitVersion", "5.10.2") // https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter-api
set("junitPioneerVersion", "2.2.0") // https://mvnrepository.com/artifact/org.junit-pioneer/junit-pioneer
set("mockitoVersion", "5.12.0") // https://mvnrepository.com/artifact/org.mockito/mockito-junit-jupiter
Expand Down
2 changes: 1 addition & 1 deletion executor/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,4 @@ tasks.test {
dependsOn(":test-service-extension-metadata:jar")
dependsOn(":test-services:jar")
dependsOn(":test-service:buildAppImage")
}
}
4 changes: 2 additions & 2 deletions executor/src/test/java/module-info.test
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
--add-modules
org.junitpioneer,org.hamcrest,guava.testlib,creek.test.util,creek.test.hamcrest,creek.test.conformity,creek.system.test.test.services,creek.system.test.test.extension,creek.system.test.test.service.extension
org.junitpioneer,org.hamcrest,guava.testlib,creek.test.util,creek.test.hamcrest,creek.test.conformity,creek.system.test.test.services,creek.system.test.test.extension,creek.system.test.test.service.extension,com.google.errorprone.annotations

--add-reads
creek.system.test.executor=org.junitpioneer,org.hamcrest,guava.testlib,creek.test.util,creek.test.hamcrest,creek.test.conformity,creek.system.test.test.services,creek.system.test.test.extension,creek.system.test.test.service.extension
creek.system.test.executor=org.junitpioneer,org.hamcrest,guava.testlib,creek.test.util,creek.test.hamcrest,creek.test.conformity,creek.system.test.test.services,creek.system.test.test.extension,creek.system.test.test.service.extension,com.google.errorprone.annotations

--add-opens
org.junitpioneer/org.junitpioneer.jupiter=org.junit.platform.commons
Expand Down

0 comments on commit 9c884a9

Please sign in to comment.