Support custom issuer #543
Open
+160
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crewjam Please take a look when you have a change. |
sword-jin
force-pushed
the
support_custom_issuer
branch
from
82fff91
to
ec49e70
Compare
sword-jin
force-pushed
the
support_custom_issuer
branch
from
ec49e70
to
52cb104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Now, the entity id of SAML idp is fixed which metadataURL which is very long in our case.
Actually, we need to custom the format to
$host/$idp-id, so I submit this PR to support it.