Add ncattrs function to get nc attributes without the need for siphon.
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmigneault
requested changes
Nov 16, 2023
…n disk for test comparisons. Normalize serviceType using Enum. Add utility functions to bypass siphon.
fmigneault
approved these changes
Nov 17, 2023
|
@huard |
|
Maybe releasing this should wait for the functions to be integrated in the populator. As it it, they're just there. |
Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't modify THREDDSLoader yet. Just added the function and tests.
@fmigneault-crim I replaced the comparison with the reference with validation. The reference was missing a few services, so the test failed.