Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix limit integration (fixes #237) #256

Merged
merged 26 commits into from
Jun 4, 2021
Merged

Conversation

trapsidanadir
Copy link
Contributor

@trapsidanadir trapsidanadir commented May 25, 2021

Added jobs validation and limit parameter against ogcapi standards (fixes #237)

@trapsidanadir trapsidanadir added this to the OGC-API Conformances milestone May 25, 2021
@trapsidanadir trapsidanadir self-assigned this May 25, 2021
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support feature/db Related to database or datatype manipulation. feature/job Issues related to job execution, reporting and logging. labels May 25, 2021
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #256 (9f2a3ff) into master (0093e24) will increase coverage by 0.16%.
The diff coverage is 98.85%.

❗ Current head 9f2a3ff differs from pull request most recent head 1570224. Consider uploading reports for the commit 1570224 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   71.80%   71.96%   +0.16%     
==========================================
  Files          61       61              
  Lines        9323     9381      +58     
  Branches     1400     1409       +9     
==========================================
+ Hits         6694     6751      +57     
+ Misses       2238     2237       -1     
- Partials      391      393       +2     
Impacted Files Coverage Δ
weaver/store/base.py 100.00% <ø> (ø)
weaver/typedefs.py 100.00% <ø> (ø)
weaver/wps_restapi/jobs/jobs.py 75.00% <96.87%> (+0.62%) ⬆️
weaver/store/mongodb.py 62.60% <100.00%> (+0.93%) ⬆️
weaver/wps_restapi/api.py 76.47% <100.00%> (+0.56%) ⬆️
weaver/wps_restapi/swagger_definitions.py 99.88% <100.00%> (+<0.01%) ⬆️
weaver/wps_restapi/colander_extras.py 77.41% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0093e24...1570224. Read the comment docs.

@trapsidanadir trapsidanadir linked an issue May 25, 2021 that may be closed by this pull request
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for details.

Please also update the CHANGES to describe the addition/validation of datetime and limit fields.
Add references to #236 (datetime) and #237 (limit).

weaver/store/__init__.py Outdated Show resolved Hide resolved
weaver/store/__init__.py Outdated Show resolved Hide resolved
weaver/store/mongodb.py Outdated Show resolved Hide resolved
weaver/store/mongodb.py Outdated Show resolved Hide resolved
weaver/store/mongodb.py Show resolved Hide resolved
tests/wps_restapi/test_jobs.py Outdated Show resolved Hide resolved
tests/wps_restapi/test_jobs.py Outdated Show resolved Hide resolved
weaver/store/mongodb.py Outdated Show resolved Hide resolved
weaver/wps_restapi/swagger_definitions.py Outdated Show resolved Hide resolved
tests/wps_restapi/test_jobs.py Show resolved Hide resolved
@fmigneault
Copy link
Collaborator

fmigneault commented May 25, 2021

@trapsidanadir
Another thing I forgot to mention.
You will also need to add the validated items to the list of supported requirements.
Refer to #231 for details.

Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are almost there.
Remaining changes are mostly related to formatting issues.

weaver/wps_restapi/api.py Outdated Show resolved Hide resolved
weaver/store/mongodb.py Outdated Show resolved Hide resolved
weaver/store/mongodb.py Outdated Show resolved Hide resolved
weaver/store/base.py Outdated Show resolved Hide resolved
tests/utils.py Outdated Show resolved Hide resolved
weaver/wps_restapi/swagger_definitions.py Outdated Show resolved Hide resolved
weaver/wps_restapi/jobs/jobs.py Outdated Show resolved Hide resolved
weaver/wps_restapi/swagger_definitions.py Outdated Show resolved Hide resolved
weaver/wps_restapi/swagger_definitions.py Outdated Show resolved Hide resolved
weaver/wps_restapi/swagger_definitions.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the last changes.
Pull the updates. I add to fix merge conflicts.

weaver/store/base.py Outdated Show resolved Hide resolved
weaver/store/base.py Show resolved Hide resolved
weaver/wps_restapi/swagger_definitions.py Outdated Show resolved Hide resolved
weaver/wps_restapi/swagger_definitions.py Outdated Show resolved Hide resolved
weaver/wps_restapi/jobs/jobs.py Outdated Show resolved Hide resolved
weaver/wps_restapi/jobs/jobs.py Outdated Show resolved Hide resolved
weaver/store/mongodb.py Outdated Show resolved Hide resolved
@fmigneault
Copy link
Collaborator

@trapsidanadir
Also need to update CHANGES.rst with added feature and link to fixed issue.

Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing CHANGES update.

CHANGES.rst Outdated Show resolved Hide resolved
weaver/wps_restapi/swagger_definitions.py Outdated Show resolved Hide resolved
@fmigneault fmigneault merged commit 716a00f into master Jun 4, 2021
@fmigneault fmigneault deleted the fix-limit-integration branch June 4, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/db Related to database or datatype manipulation. feature/job Issues related to job execution, reporting and logging. feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Limit query validation and integration
2 participants