-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python file2stringarray #278
Open
fmigneault
wants to merge
7
commits into
master
Choose a base branch
from
fix-python-file2stringarray
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci/doc
Issue related to documentation of the package
ci/tests
Tests of the package and features
feature/CWL
Issue related to CWL support
process/builtin
Issue related to builtin application processes
labels
Jul 16, 2021
dbyrns
previously approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything look good.
matprov
previously approved these changes
Jul 19, 2021
…test file-handling mocks to provide more details
matprov
approved these changes
Aug 17, 2021
dbyrns
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/doc
Issue related to documentation of the package
ci/tests
Tests of the package and features
feature/CWL
Issue related to CWL support
process/builtin
Issue related to builtin application processes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This update changes the internal operation accomplished by
file2string_array
process since it was attempting to create directly a CWL output of typeFile[]
.To do that, it was actually hijacking the internal file
cwl.output.json
ofcwltool
by directly populating the contents of the expected output after process execution rather than letting the engine generate it, but format was invalid and still failing the execution anyway. The actual CWL content definition was defined asFile
, which did not match with the generatedFile[]
pushed incwl.output.json
.Multi-output (
File[]
) is also not yet supported inWeaver
(see #25) becauseOGC API - Processes
does not allow output multiplicity under a same output ID.It as been decided that output should be adjusted to be a single
File
.This better matches the original description of the process anyway, because old implementation was not even producing a JSON output file:
Changes
file2string_array
process so it does whatit actually advertises in its
abstract
description and doesn't result in error after execution.Fixes
python
reference infile2string_array
process CWL definition (fixes [BUG] CWLTool throw error the missing folder for Python dist #275).version
field definition forfile2string_array
process and set it as1.0
.