Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add smoke tests scripts to evaluate node.js dependency within built docker image #561

Merged
merged 3 commits into from
Sep 14, 2023
Merged

add smoke tests scripts to evaluate node.js dependency within built docker image #561

merged 3 commits into from
Sep 14, 2023

Conversation

fmigneault
Copy link
Collaborator

Fixes

  • Fix missing Node.js requirement in built Docker image in order to evaluate definitions that employ
    CWL InlineJavascriptRequirement, such as valueFrom employed for numeric Enum input type validation.

@fmigneault fmigneault added ci/tests Tests of the package and features feature/CWL Issue related to CWL support feature/docker Issue related to Docker application package execution. labels Sep 14, 2023
@fmigneault fmigneault self-assigned this Sep 14, 2023
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) labels Sep 14, 2023
perronld
perronld previously approved these changes Sep 14, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #561 (45dba29) into master (3b8d66d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #561   +/-   ##
=======================================
  Coverage   84.46%   84.46%           
=======================================
  Files          79       79           
  Lines       17703    17703           
  Branches     2685     2685           
=======================================
  Hits        14952    14952           
  Misses       2022     2022           
  Partials      729      729

@fmigneault fmigneault merged commit de9fba2 into master Sep 14, 2023
43 checks passed
@fmigneault fmigneault deleted the fix-nodejs-requirement branch September 14, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perronld perronld perronld left review comments

Assignees

@fmigneault fmigneault

Labels
ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/CWL Issue related to CWL support feature/docker Issue related to Docker application package execution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmigneault @perronld