Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job execution results #713

Merged
merged 80 commits into from
Oct 12, 2024
Merged

job execution results #713

merged 80 commits into from
Oct 12, 2024

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Sep 13, 2024

Description

Updates of job execution modes and results reporting considering:

to simplify review, consider using the rendered documentation:
https://pavics-weaver--713.org.readthedocs.build/en/713/processes.html#execution-of-a-process-execute

To Do

  • update /conformance links
  • check Link headers in response
  • review linked issues for other "todo"
  • update changes with linked issues (each feature/param support added)
  • update changes with doc updates mention
  • update changes with support of multipart
  • update changes with transmissionMode correctly handled

@fmigneault fmigneault self-assigned this Sep 13, 2024
@github-actions github-actions bot added the ci/doc Issue related to documentation of the package label Sep 13, 2024
@github-actions github-actions bot added ci/tests Tests of the package and features feature/job Issues related to job execution, reporting and logging. feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels Sep 16, 2024
@github-actions github-actions bot added the feature/quotation Issues related to quotation, billing and estimators. label Sep 19, 2024
…planned test for result by ID with accept (relates to #18)
@github-actions github-actions bot added feature/cli Issues or features related to CLI operations. feature/db Related to database or datatype manipulation. labels Sep 20, 2024
@github-actions github-actions bot added feature/db Related to database or datatype manipulation. feature/oas Issues related to OpenAPI specifications. feature/quotation Issues related to quotation, billing and estimators. labels Oct 9, 2024
@fmigneault fmigneault marked this pull request as ready for review October 9, 2024 16:28
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 88.99083% with 72 lines in your changes missing coverage. Please review.

Project coverage is 86.39%. Comparing base (cd6b5d4) to head (ae469c7).
Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
weaver/utils.py 79.46% 17 Missing and 6 partials ⚠️
weaver/wps_restapi/jobs/utils.py 91.60% 13 Missing and 8 partials ⚠️
weaver/datatype.py 80.00% 10 Missing and 1 partial ⚠️
weaver/cli.py 77.27% 4 Missing and 1 partial ⚠️
weaver/execute.py 94.62% 2 Missing and 3 partials ⚠️
weaver/processes/execution.py 88.88% 2 Missing and 1 partial ⚠️
weaver/processes/convert.py 71.42% 1 Missing and 1 partial ⚠️
weaver/processes/wps_process_base.py 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
+ Coverage   86.08%   86.39%   +0.31%     
==========================================
  Files          80       80              
  Lines       19577    19988     +411     
  Branches     2629     2709      +80     
==========================================
+ Hits        16852    17269     +417     
+ Misses       1983     1978       -5     
+ Partials      742      741       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/wps_restapi/test_jobs.py Show resolved Hide resolved
weaver/execute.py Show resolved Hide resolved
Nazim-crim
Nazim-crim previously approved these changes Oct 11, 2024
Copy link
Contributor

@Nazim-crim Nazim-crim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

weaver/wps_restapi/jobs/utils.py Show resolved Hide resolved
weaver/wps_restapi/jobs/utils.py Show resolved Hide resolved
weaver/wps_restapi/jobs/utils.py Outdated Show resolved Hide resolved
@fmigneault fmigneault merged commit 506f9c4 into master Oct 12, 2024
48 checks passed
@fmigneault fmigneault deleted the job-prefer branch October 12, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/CWL Issue related to CWL support feature/db Related to database or datatype manipulation. feature/docker Issue related to Docker application package execution. feature/job Issues related to job execution, reporting and logging. feature/oas Issues related to OpenAPI specifications. feature/providers Issue related to providers convertion to WPS-REST processes. feature/quotation Issues related to quotation, billing and estimators. process/builtin Issue related to builtin application processes process/workflow Related to a Workflow process. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
3 participants