Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Job POST/PATCH operations for Part 4 Job Management #746

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Oct 26, 2024

@fmigneault fmigneault self-assigned this Oct 26, 2024
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/db Related to database or datatype manipulation. feature/job Issues related to job execution, reporting and logging. feature/oas Issues related to OpenAPI specifications. feature/providers Issue related to providers convertion to WPS-REST processes. process/builtin Issue related to builtin application processes process/workflow Related to a Workflow process. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels Oct 26, 2024
@fmigneault fmigneault changed the base branch from master to job-management-execute October 26, 2024 04:31
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.07%. Comparing base (5c3b294) to head (28cb33c).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
weaver/cli.py 91.66% 4 Missing and 7 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files          80       80           
  Lines       20395    20472   +77     
  Branches     2774     2784   +10     
=======================================
+ Hits        17758    17827   +69     
- Misses       1900     1902    +2     
- Partials      737      743    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmigneault
Copy link
Collaborator Author

@languith Using https://github.com/crim-ca/weaver/tree/job-management-execute base branch to keep the diff smaller :)

weaver/cli.py Show resolved Hide resolved
Nazim-crim
Nazim-crim previously approved these changes Nov 13, 2024
Base automatically changed from job-management-execute to master November 13, 2024 21:51
@fmigneault fmigneault dismissed Nazim-crim’s stale review November 13, 2024 21:51

The base branch was changed.

@fmigneault fmigneault merged commit 0cebfa0 into master Nov 13, 2024
51 checks passed
@fmigneault fmigneault deleted the job-post-cli branch November 13, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/db Related to database or datatype manipulation. feature/job Issues related to job execution, reporting and logging. feature/oas Issues related to OpenAPI specifications. feature/providers Issue related to providers convertion to WPS-REST processes. process/builtin Issue related to builtin application processes process/workflow Related to a Workflow process. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants