Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all libz-sys code with flate2 #173

Open
wants to merge 4 commits into
base: oxidize
Choose a base branch
from
Open

Replace all libz-sys code with flate2 #173

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c71742a
use flate2 crate for pdf_add_stream_flate
cormacrelf Oct 28, 2019
10f2703
more flate2
cormacrelf Oct 28, 2019
5a5e070
fully replace libz-sys with flate2
cormacrelf Oct 28, 2019
a8e3e1e
Use the default (miniz_oxide) backend of flate2 instead of zlib.
cormacrelf Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 2 additions & 5 deletions dpx/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,12 @@ license = "GPL"
tectonic_bridge = { version = "0.0.1-dev", path = "../bridge" }
libc = "0.2"
libpng-sys = "1.1.8"
libz-sys = { version = "1", optional = true}
md-5 = "0.8.0"
sha2 = "0.8.0"
rand = "0.7.2"
chrono = "0.4.9"

[features]
default = ['libz-sys']
legacy-libz = ['libz-sys']
# to ensure binaries are not different, we link to libz-sys
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is inaccurate, I'm not sure there's really a backwards-compatibility point in keeping the zlib linking. I think the default backend runs about as quickly as zlib.

Copy link
Collaborator Author

@cormacrelf cormacrelf Oct 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With zlib, 273 diffs: https://tt.ente.ninja/#/compare/c188c51eadc8dfcc46b77819b7b8ac7d374e582b/5a5e070ef6bbdeb6e06d1956233d31e402a158cd

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With default, every file is different.

flate2 = { version = "1.0.12", default-features = false, features = ["zlib"] }

[build-dependencies]
cc = "^1.0"
Loading