Features #123
Merged
Features #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 30, 2024 12:54
Introduce a new Prometheus gauge `CurrentRequests` to track the number of current requests in `statistics.go`. Update `http.go` to set this gauge based on the current number of active connections and improve metric labeling for request times. Signed-off-by: Christian Roessner <[email protected]>
Introduced new Prometheus metrics to track the time since the application last reloaded and since it started. Modified the instance info metric to remove the instance label, focusing solely on the version label. Signed-off-by: Christian Roessner <[email protected]>
Integrate Prometheus metrics for monitoring HTTP requests across multiple Lua modules. This includes creating and updating counters and timers for specific actions, thus enhancing observability and performance tracking. Signed-off-by: Christian Roessner <[email protected]>
Updated the Prometheus timer metric string format to align with naming conventions. This change ensures consistency by placing 'total' at the end of the metric name. Signed-off-by: Christian Roessner <[email protected]>
Changed the metrics for last reload and application start to report Unix timestamps instead of seconds since the events. This provides precise timestamps for better tracking and analysis. Signed-off-by: Christian Roessner <[email protected]>
Updated the metric names to be more concise and self-explanatory, removing the prefix "nauthilus" for simplicity. This improves readability and makes the metric names more intuitive for developers and operators. Signed-off-by: Christian Roessner <[email protected]>
Added comments to enhance the readability and understanding of various metrics and synchronization variables used in the statistics module. This includes detailed explanations for Prometheus metrics and the mutex used during configuration reload operations. Signed-off-by: Christian Roessner <[email protected]>
This change updates the naming convention for Prometheus metrics to better reflect the data they represent, moving from a general counter to a specific duration in seconds. This helps in improving the clarity and accuracy of the metrics monitoring system. Signed-off-by: Christian Roessner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.