Features #135
Closed
Features #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 15, 2024 14:40
Implemented a ConnectionManager to track and manage network connections. Added Lua bindings for registering and querying connection targets, as well as Prometheus metric for active connections. Updated project dependencies to support this feature. Signed-off-by: Christian Roessner <[email protected]>
Implemented a ConnectionManager to track and manage network connections. Added Lua bindings for registering and querying connection targets, as well as Prometheus metric for active connections. Updated project dependencies to support this feature. Signed-off-by: Christian Roessner <[email protected]>
# Conflicts: # server/lualib/connmgr/netstats.go
Introduced the `GenericConnections` metric to track active connections with labels for description, target, and direction. Added support for registering connection targets with descriptions and provided a new function to update the connection metrics dynamically. Signed-off-by: Christian Roessner <[email protected]>
Implement `validateDNSResolver` to ensure DNS resolver entries are in valid host:port format in the Server configuration. Adjust `NewDNSResolver` to use the provided resolver setting directly, aligning with the new validation checks. Signed-off-by: Christian Roessner <[email protected]>
Integrated nauthilus_psnet module across haveibeenpwnd, blocklist, backend, and geoip Lua plugins. This inclusion enables registering remote connection targets for enhanced network communication handling. Signed-off-by: Christian Roessner <[email protected]>
Update the connection target to include the port 443 for secure communication. This change ensures that the HTTP request to the pwnedpasswords API is correctly routed and handled. Signed-off-by: Christian Roessner <[email protected]>
Centralize HTTP client initialization with consistent settings across various packages by introducing InitHTTPClient method. The global httpClient variable is now pre-configured once at startup, eliminating redundant client creation and closure, resulting in cleaner and more maintainable code. Signed-off-by: Christian Roessner <[email protected]>
Introduced a ticker-based IP monitoring system to the ConnectionManager to check for IP updates at regular intervals. This includes adding `StartMonitoring` and auxiliary functions such as `equalIPs`, and `checkForIPUpdates`, as well as integrating the new monitoring process into the server's lifecycle. Signed-off-by: Christian Roessner <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| for _, ip := range m.ipTargets[target] { | ||
| if ip == "0.0.0.0" || ip == "::" || ip == addr.IP { | ||
| if addr.Port == uint32(port) { |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 4 months ago
To fix the problem, we need to ensure that the integer value parsed from the string is within the valid range for uint32 before performing the cast. This can be achieved by using strconv.ParseUint with a specified bit size of 32, which will directly return a uint64 value. We can then safely cast this value to uint32 after ensuring it is within the valid range.
- Replace the use of
strconv.Atoiwithstrconv.ParseUintspecifying a bit size of 32. - Ensure the parsed value is within the valid range for
uint32before casting.
Suggested changeset
1
server/lualib/connmgr/netstats.go
| @@ -246,3 +246,3 @@ | ||
|
|
||
| port, err := strconv.Atoi(portStr) | ||
| port64, err := strconv.ParseUint(portStr, 10, 32) | ||
| if err != nil { | ||
| @@ -252,2 +252,3 @@ | ||
| } | ||
| port := uint32(port64) | ||
|
|
||
| @@ -265,3 +266,3 @@ | ||
| if ip == "0.0.0.0" || ip == "::" || ip == addr.IP { | ||
| if addr.Port == uint32(port) { | ||
| if addr.Port == port { | ||
| count++ |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.