Features #166
Merged
Features #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 19, 2024 21:15
Refactored client fields in `JSONRequest` struct to be optional using `omitempty` tag. Added several new SSL/TLS fields to support enhanced authentication details. Removed return value from `setAuthenticationFields` function and updated code accordingly. Signed-off-by: Christian Roessner <[email protected]>
Replaced the Service field with Protocol in the auth structure. This change utilizes the NewProtocol function to set the Protocol field, enhancing clarity and specificity. Signed-off-by: Christian Roessner <[email protected]>
Reorganize the placement of the authentication cache headers to follow successful authentication. Update the caching header names for better clarity and consolidate redundant conditions. Remove the unnecessary "X-User-Found" header. Signed-off-by: Christian Roessner <[email protected]>
Renamed the setUserInfoHeaders function to sendAuthResponse for clarity and consolidated the functionality into a single method. Simplified comments and adjusted all references to reflect this change, improving the code's readability and maintainability. Signed-off-by: Christian Roessner <[email protected]>
Removed unnecessary 'logKey' and 'logger' variables from the logger middleware. Simplified the logging statement by using constants directly, improving code clarity and maintainability. Signed-off-by: Christian Roessner <[email protected]>
Enhanced JSON binding by adding required field validators and IP address format checks in structures. Introduced `handleJSONError` method for clearer validation error messages and refactored existing JSON parsing logic to use it. Signed-off-by: Christian Roessner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.