feat: add pool_max_idle, pool_idle_timeout to MySQL settings

croquiscom · Jun 25, 2024 · d7e089d · d7e089d
1 parent f298688
commit d7e089d
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/packages/cormo/examples/typescript/basic.ts b/packages/cormo/examples/typescript/basic.ts
@@ -13,11 +13,15 @@ export const connection = new cormo.MySQLConnection({
         password: 'cormo_test',
         port: 21860,
         user: 'cormo_test',
+        pool_max_idle: 2,
+        pool_idle_timeout: 5000,
       },
     ],
   },
   user: 'cormo_test',
   connection_retry_count: 2,
+  pool_max_idle: 2,
+  pool_idle_timeout: 5000,
 });
 
 class Name {

diff --git a/packages/cormo/lib/adapters/mysql.d.ts b/packages/cormo/lib/adapters/mysql.d.ts
@@ -13,6 +13,8 @@ export interface AdapterSettingsMySQL {
     charset?: string;
     collation?: string;
     pool_size?: number;
+    pool_max_idle?: number;
+    pool_idle_timeout?: number;
     query_timeout?: number;
     max_lifetime?: number;
     replication?: {
@@ -23,6 +25,8 @@ export interface AdapterSettingsMySQL {
             user?: string | Promise<string>;
             password?: string | Promise<string>;
             pool_size?: number;
+            pool_max_idle?: number;
+            pool_idle_timeout?: number;
         }>;
     };
     ssl?: string | (tls.SecureContextOptions & {

diff --git a/packages/cormo/lib/adapters/mysql.js b/packages/cormo/lib/adapters/mysql.js
@@ -786,6 +786,8 @@ class MySQLAdapter extends sql_base_1.SQLAdapterBase {
         this._client = mysql.createPool({
             charset: settings.charset,
             connectionLimit: settings.pool_size || 10,
+            maxIdle: settings.pool_max_idle,
+            idleTimeout: settings.pool_idle_timeout,
             database: settings.database,
             host: settings.host,
             password: await settings.password,
@@ -808,6 +810,8 @@ class MySQLAdapter extends sql_base_1.SQLAdapterBase {
                 const read_client = mysql.createPool({
                     charset: settings.charset,
                     connectionLimit: replica.pool_size || 10,
+                    maxIdle: settings.pool_max_idle,
+                    idleTimeout: settings.pool_idle_timeout,
                     database: settings.database,
                     host: replica.host,
                     password: await replica.password,

diff --git a/packages/cormo/src/adapters/mysql.ts b/packages/cormo/src/adapters/mysql.ts
@@ -42,6 +42,8 @@ export interface AdapterSettingsMySQL {
   charset?: string;
   collation?: string;
   pool_size?: number;
+  pool_max_idle?: number;
+  pool_idle_timeout?: number;
   query_timeout?: number;
   max_lifetime?: number;
   replication?: {
@@ -52,6 +54,8 @@ export interface AdapterSettingsMySQL {
       user?: string | Promise<string>;
       password?: string | Promise<string>;
       pool_size?: number;
+      pool_max_idle?: number;
+      pool_idle_timeout?: number;
     }>;
   };
   ssl?: string | (tls.SecureContextOptions & { rejectUnauthorized?: boolean });
@@ -864,6 +868,8 @@ export class MySQLAdapter extends SQLAdapterBase {
     this._client = mysql.createPool({
       charset: settings.charset,
       connectionLimit: settings.pool_size || 10,
+      maxIdle: settings.pool_max_idle,
+      idleTimeout: settings.pool_idle_timeout,
       database: settings.database,
       host: settings.host,
       password: await settings.password,
@@ -887,6 +893,8 @@ export class MySQLAdapter extends SQLAdapterBase {
         const read_client = mysql.createPool({
           charset: settings.charset,
           connectionLimit: replica.pool_size || 10,
+          maxIdle: settings.pool_max_idle,
+          idleTimeout: settings.pool_idle_timeout,
           database: settings.database,
           host: replica.host,
           password: await replica.password,