Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated(rewrite) to use etcd backend and SkyDNS v2 #68

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Updated(rewrite) to use etcd backend and SkyDNS v2 #68

wants to merge 42 commits into from

Conversation

cptactionhank
Copy link

No description provided.

ms and others added 29 commits June 11, 2014 03:11
Automatic PTR record creation
@wyaeld
Copy link

wyaeld commented Jul 12, 2014

The License text now reads copyright cptactionhank
The Dockerfile also references your fork of skydock.
I suspect both of those are minor mistakes that slipped through.

IANTM, but the work looks really good.


Skydock monitors docker events when containers _start, stop, die, kill_, etc and inserts records into a [etcd](https://github.com/coreos/etcd) key/value store which [SkyDNS](https://github.com/skynetservices/skydns) uses as DNS backend. This allows standard DNS queries for services running inside docker containers. Because lets face it, if you have to modify your application code to work with other service discovery solutions you might as well just give up. DNS just works and it works well. Also you cannot be expected to modify application code that you don't own. Passing service urls via the cli or in static config files (nginx) will not be possible if your service discovery solution requires a client library just to fetch an IP address.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert this back to the multiple lines it was, that will make this diff much smaller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants