Conversation
```
error: incorrect implementation of `clone` on a `Copy` type
--> crossbeam-epoch/src/atomic.rs:1171:29
|
1171 | fn clone(&self) -> Self {
| _____________________________^
1172 | | Self {
1173 | | data: self.data,
1174 | | _marker: PhantomData,
1175 | | }
1176 | | }
| |_____^ help: change this to: `{ *self }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_clone_impl_on_copy_type
= note: `#[deny(clippy::incorrect_clone_impl_on_copy_type)]` on by default
error: incorrect implementation of `clone` on a `Copy` type
--> crossbeam-deque/src/deque.rs:82:34
|
82 | fn clone(&self) -> Buffer<T> {
| __________________________________^
83 | | Buffer {
84 | | ptr: self.ptr,
85 | | cap: self.cap,
86 | | }
87 | | }
| |_____^ help: change this to: `{ *self }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_clone_impl_on_copy_type
= note: `#[deny(clippy::incorrect_clone_impl_on_copy_type)]` on by default
```
``` error: call to `.clone()` on a reference in this situation does nothing --> crossbeam-epoch/src/guard.rs:451:38 | 14 | let dummy = &epoch::unprotected().clone(); | ^^^^^^^^ help: remove this redundant call | = note: the type `Guard` does not implement `Clone`, so calling `clone` on `&Guard` copies the reference, which does not do anything and can be removed note: the lint level is defined here --> crossbeam-epoch/src/guard.rs:438:9 | 1 | #![deny(warnings, rust_2018_idioms)] | ^^^^^^^^ = note: `#[deny(noop_method_call)]` implied by `#[deny(warnings)]` ```
The perf c2c data shows lots of cacheline contention were caused by false sharing between epoch and other field in "Local" struct. So use CachePadded class to align it to another cacheline to resolve this issue.
core::panic::{,Ref}UnwindSafe is available on Rust 1.56+.
Replaces #724. Co-authored-by: Enkelmann <nils-edvin.enkelmann@fkie.fraunhofer.de>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
- crossbeam-channel 0.5.8 -> 0.5.9 - crossbeam-deque 0.8.3 -> 0.8.4 - crossbeam-epoch 0.9.15 -> 0.9.16 - crossbeam-queue 0.3.8 -> 0.3.9 - crossbeam-utils 0.8.16 -> 0.8.17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scopeguard. (Various cleanups #1045)loomdependency to 0.7.{,Ref}UnwindSafefor AtomicCell. (Various cleanups #1045)oom=panic. (Various cleanups #1045)CachePadded. (CachePadded: update alignment for mips32r6 and mips64r6 #1014, CachePadded: Use 64-byte alignment on riscv32 and riscv64 #1025)loomdependency to 0.7.Closes #1048
skiplist is in the master branch, so I'll release it in another PR.