replace int_to_ptr_with_provenance by map_addr-style function#1184
Merged
taiki-e merged 1 commit intocrossbeam-rs:masterfrom Mar 20, 2025
Merged
replace int_to_ptr_with_provenance by map_addr-style function#1184taiki-e merged 1 commit intocrossbeam-rs:masterfrom
taiki-e merged 1 commit intocrossbeam-rs:masterfrom
Conversation
Contributor
Author
|
That clippy failure is in a file I did not even change... seems like clippy isn't pinned so PRs can fail for unrelated reasons? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #796 was added,
int_to_ptr_with_provenancewas a new idea and looked like a hack. Now that strict provenance is stable, this is calledwith_addrand looks like a very normal API. ;) And in fact, there's an even nicer API on top of it,map_addr. We can't use it here yet since the MSRV of Rust 1.61 does not have the strict provenance API, but we can still update code and comments to match the state of the art and to make it easier to eventually use the standard APIs.