Conversation
Member
Author
|
bors r+ |
Contributor
|
Canceled. |
Member
Author
|
bors r+ |
Contributor
|
Build failed: |
09b5fc0 to
9ef02eb
Compare
Load as `MaybeUninit` because we may load a value that is not valid as `T`.
This fixes stacked borrows violation violations.
Member
Author
|
Hmm, Miri failed with ICE... https://github.com/crossbeam-rs/crossbeam/runs/7411416824?check_suite_focus=true However, I cannot reproduce this ICE in #796 which is based on this PR. |
Contributor
|
Hm yeah that is weird. Do you have a reproducible testcase? |
Contributor
|
Ah, got one. Tracking this in Miri as rust-lang/miri#2389. |
Member
Author
|
Thanks! |
Member
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.