Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile to add nonroot user and arm64 AWS binaries #25

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Update Dockerfile to add nonroot user and arm64 AWS binaries #25

merged 3 commits into from
Dec 17, 2024

Conversation

stevendborrelli
Copy link
Collaborator

@stevendborrelli stevendborrelli commented Dec 13, 2024 •
edited
Loading

Description of your changes

Updates the username the container runs as, sets up builds for arm64 and x86_64 AWS CLI images.

Fixes #24, #23

I have:

Testing

From the arm64 build:

2024-12-13T14:02:16.3177461Z #17 0.057 Installing aws-cli for linux/arm64

From the amd64 build:

#17 0.069 Installing aws-cli for linux/x86_64

@stevendborrelli
update Dockerfile
0e7576f 
Signed-off-by: Steven Borrelli <[email protected]>
@stevendborrelli
remove comment
2feab0d 
Signed-off-by: Steven Borrelli <[email protected]>
@stevendborrelli
add ARG to Dockerfile
dd08a38 
Signed-off-by: Steven Borrelli <[email protected]>
@stevendborrelli stevendborrelli changed the title update Dockerfile Update Dockerfile to add nonroot user and arm64 AWS binaries Dec 13, 2024
humoflife
humoflife approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@humoflife humoflife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes. Looks good.

@stevendborrelli stevendborrelli merged commit da833b9 into crossplane-contrib:main Dec 17, 2024
6 checks passed
@stevendborrelli stevendborrelli deleted the update-dockerfile branch December 17, 2024 23:45
@stevendborrelli stevendborrelli mentioned this pull request Dec 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humoflife humoflife humoflife approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to fix user permissions
2 participants
@stevendborrelli @humoflife