New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated unit tests, removed v1beta1, simplfied code, updated README #9

Merged

humoflife merged 1 commit into crossplane-contrib:main from humoflife:unit-tests

Apr 22, 2024

Collaborator

humoflife commented Apr 20, 2024 •

edited

Loading

Description of your changes

Fixes

unit test that passes locally but not in github actions.
leftover artifact from input/v1beta1
go loop that is now written more simple
typo in README

I have:

Read and followed Crossplane's
contribution process. Also see docs.
Added or updated unit tests for my change.


          updated unit tests, removed v1beta1, simplfied code, updated README

a3be6f6

Signed-off-by: humoflife <[email protected]>

humoflife force-pushed the unit-tests branch from 982a6bb to a3be6f6 Compare

April 20, 2024 00:30

humoflife requested a review from stevendborrelli

April 20, 2024 00:37

stevendborrelli approved these changes

View reviewed changes

stevendborrelli approved these changes

View reviewed changes

humoflife merged commit 8cd3370 into crossplane-contrib:main

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet