Skip to content

Commit

Permalink
Merge pull request #1575 from achetronic/chore/document-bucket-field-…
Browse files Browse the repository at this point in the history
…error
  • Loading branch information
MisterMX authored Nov 22, 2022
2 parents b7bc0a6 + 0056275 commit 095bdea
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
3 changes: 3 additions & 0 deletions apis/s3/v1beta1/bucket_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ type BucketParameters struct {

// LocationConstraint specifies the Region where the bucket will be created.
// It is a required field.
// Due to AWS API limitations lacking on a proper response, when this field is set to a wrong value,
// or to non-existent region on bucket creation, it's impossible forwarding a meaningful status message to the user
// about the problem, producing connection errors instead.
LocationConstraint string `json:"locationConstraint"`

// Allows grantee the read, write, read ACP, and write ACP permissions on the
Expand Down
6 changes: 5 additions & 1 deletion package/crds/s3.aws.crossplane.io_buckets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,11 @@ spec:
type: object
locationConstraint:
description: LocationConstraint specifies the Region where the
bucket will be created. It is a required field.
bucket will be created. It is a required field. Due to AWS API
limitations lacking on a proper response, when this field is
set to a wrong value, or to non-existent region on bucket creation,
it's impossible forwarding a meaning status message to the user
about the problem, producing some errors related to dial
type: string
loggingConfiguration:
description: Specifies logging parameters for an Amazon S3 bucket.
Expand Down

0 comments on commit 095bdea

Please sign in to comment.