feat(docdb): observe engineVersion + fix/add unit-test cases

Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <[email protected]>

apis/docdb/generator-config.yaml

@@ -5,6 +5,11 @@ resources:
         from:
           operation: ModifyDBCluster
           path: AllowMajorVersionUpgrade
+      EngineVersion:
+        is_read_only: true
+        from:
+          operation: DescribeDBClusters
+          path: DBClusters.EngineVersion
 
 ignore:
   field_paths:

apis/docdb/v1alpha1/custom_types.go

@@ -31,6 +31,8 @@ const (
 	DocDBInstanceStateDeleting = "deleting"
 	// The instance is being modified.
 	DocDBInstanceStateModifying = "modifying"
+	// The instance is being upgraded.
+	DocDBInstanceStateUpgrading = "upgrading"
 	// The instance has failed and Amazon RDS can't recover it. Perform a point-in-time restore to the latest restorable time of the instance to recover the data.
 	DocDBInstanceStateFailed = "failed"
 )

package/crds/docdb.aws.crossplane.io_dbclusters.yaml

@@ -993,6 +993,9 @@ spec:
                     description: Specifies the connection endpoint for the primary
                       instance of the cluster.
                     type: string
+                  engineVersion:
+                    description: Indicates the database engine version.
+                    type: string
                   hostedZoneID:
                     description: Specifies the ID that Amazon Route 53 assigns when
                       you create a hosted zone.

pkg/controller/docdb/dbcluster/setup.go

@@ -124,6 +124,9 @@ func (e *hooks) postObserve(ctx context.Context, cr *svcapitypes.DBCluster, resp
 		return managed.ExternalObservation{}, err
 	}
 
+	cluster := resp.DBClusters[0]
+	cr.Status.AtProvider.EngineVersion = cluster.EngineVersion
+
 	obs.ConnectionDetails = getConnectionDetails(cr)
 
 	if !meta.WasDeleted(cr) {
@@ -180,6 +183,10 @@ func lateInitialize(cr *svcapitypes.DBClusterParameters, resp *svcsdk.DescribeDB
 func (e *hooks) isUpToDate(ctx context.Context, cr *svcapitypes.DBCluster, resp *svcsdk.DescribeDBClustersOutput) (bool, string, error) {
 	cluster := resp.DBClusters[0]
 
+	if pointer.StringValue(cluster.Status) == svcapitypes.DocDBInstanceStateModifying || pointer.StringValue(cluster.Status) == svcapitypes.DocDBInstanceStateUpgrading {
+		return true, "", nil
+	}
+
 	_, pwChanged, err := e.getPasswordFromRef(ctx, cr.Spec.ForProvider.MasterUserPasswordSecretRef, cr.Spec.WriteConnectionSecretToReference)
 	if err != nil || pwChanged {
 		return false, "", err