chore: Add context to ACK isUpToDate and return diff #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterMX
force-pushed
the
chore/isuptodate-context-diff
branch
4 times, most recently
from
baeefce to
8fc2fbb
Compare
|
I'm not super fan about the name utils, ref. https://github.com/golang/go/wiki/CodeReviewComments#package-names - if you have an alternative that would be nice. And as you say, we should wait with this until merged upstream to prevent depending on a unmerged PR. maybe in a followup, it would be nice if cases like this returned a hint like "spec.forProvider.pitStatus" instead of the empty string? |
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <[email protected]>
MisterMX
force-pushed
the
chore/isuptodate-context-diff
branch
from
8fc2fbb to
c230c38
Compare
chlunde
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1828
Depends on aws-controllers-k8s/code-generator#458
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Most of the code remains untouched. Only function parameters were added and
context.TODOwas replaced with the real context. In some cases the controllers and tests needed to bed changed since their weren't using the...WithContextAPIs. In some other casescmp.Equalwas replaced withdiff := cmp.Diff(...); diff != ""to keep the diff and return it later.