chores: Update build submodule and up up cli version #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianAvila
force-pushed
the
update-build-versions
branch
3 times, most recently
from
df9c2f7
to
ae39061
Compare
MisterMX
approved these changes
Jul 4, 2024
up cli version is now compatible with docker >= 1.25 Signed-off-by: ChristianAvila <[email protected]>
make vendor was deprecated in favor of modules.download and vendor.check to modules.check Signed-off-by: ChristianAvila <[email protected]>
Signed-off-by: ChristianAvila <[email protected]>
ChristianAvila
force-pushed
the
update-build-versions
branch
from
f759fde
to
8fa522d
Compare
|
Thanks @MisterMX, I noticed an error in the check diff and e2e-tests. Both have been fixed in my latest commit. Can you please help me with a review? Both actions are now running smoothly in my repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
vendorandvendor.checkwere deprecated, updated the CI to use the new versionmodules.downloadandmodules.checkGo Targets: modules.download Download Go modules. modules.check Fail the build if Go modules have changed.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested