Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudwatch): Add resource policy resource #2086

Conversation

stefnans
Copy link
Contributor

@stefnans stefnans commented Aug 13, 2024

Description of your changes

This PR adds support for resource ResourcePolicy in the cloudwatchlogs (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-logs-resourcepolicy.html) service.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@stefnans stefnans force-pushed the feature/cloudwatch-resource-policy-resource branch from af749fc to 8ec7b3f Compare August 13, 2024 15:02
@stefnans stefnans force-pushed the feature/cloudwatch-resource-policy-resource branch from 8ec7b3f to eccae59 Compare August 14, 2024 08:35
@MisterMX MisterMX changed the title Feature/cloudwatch resource policy resource feat(cloudwatch): Add resource policy resource Aug 14, 2024
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @stefnans!

@MisterMX MisterMX merged commit 34115e2 into crossplane-contrib:master Aug 14, 2024
9 checks passed
@teeverr teeverr deleted the feature/cloudwatch-resource-policy-resource branch October 3, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants