Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eks): SubnetIds diff #2114

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix(eks): SubnetIds diff #2114

merged 1 commit into from
Oct 30, 2024

Conversation

simwak
Copy link
Contributor

@simwak simwak commented Oct 30, 2024

Fixes the diff of subnetIds.

Fixes:

cannot update EKS cluster configuration: InvalidParameterException:
      No changes needed for the provided vpc config.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Reordered the subnetIds to create the mentioned error, tested if it appears with the fix

@simwak
fix(eks): SubnetIds diff
5d630c5 
Signed-off-by: Simon Wakenhut <[email protected]>
MisterMX
MisterMX approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @simwak!

@MisterMX MisterMX merged commit 64d009a into crossplane-contrib:master Oct 30, 2024
9 checks passed
@github-actions GitHub Actions
Copy link

Successfully created backport PR #2115 for release-0.50.

@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisterMX MisterMX MisterMX approved these changes

Assignees
No one assigned
Labels
backport release-0.50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simwak @MisterMX