Skip to content

Commit

Permalink
Convert all singleton lists in the MR APIs to embedded objects
Browse files Browse the repository at this point in the history
- Terraform configuration blocks, even if they have a MaxItems
  constraint of 1, are (almost) always generated as lists. We
  now generate the lists with a MaxItems constraint of 1 as
  embedded objects in our MR APIs.
- This also helps when updating or patching via SSA the
  (previously list) objects. The merging strategy implemented
  by SSA requires configuration for associative lists and
  converting the singleton lists into embedded objects removes
  the configuration need.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
  • Loading branch information
ulucinar committed Apr 17, 2024
1 parent 1f36853 commit 5e633d6
Show file tree
Hide file tree
Showing 21 changed files with 1,932 additions and 2,207 deletions.
36 changes: 18 additions & 18 deletions apis/applications/v1beta1/zz_application_types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

108 changes: 36 additions & 72 deletions apis/applications/v1beta1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5e633d6

Please sign in to comment.