Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Terraform provider version to v2.47.0 #110

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Mar 12, 2024

Description of your changes

In this PR:

  • Upgraded Terraform provider version to v2.47.0
  • Bump crossplane/upjet to the commit 50919febc5ab

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested with uptest in the comments below.

@turkenf
Copy link
Collaborator Author

turkenf commented Mar 12, 2024

/test-examples="examples/applications/application.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Mar 12, 2024

/test-examples="examples/groups/member.yaml"

@turkenf turkenf force-pushed the update-tf-provider-2.47.0 branch from 5c37b86 to c1c2daa Compare March 20, 2024 14:57
@turkenf turkenf force-pushed the update-tf-provider-2.47.0 branch from c1c2daa to e7736d7 Compare March 20, 2024 15:05
@turkenf
Copy link
Collaborator Author

turkenf commented Mar 20, 2024

/test-examples="examples/applications/application.yaml"

Uptest run: https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/8361264948

@turkenf
Copy link
Collaborator Author

turkenf commented Mar 20, 2024

/test-examples="examples/administrativeunits/unit.yaml"

Uptest run: https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/8361268534

@turkenf
Copy link
Collaborator Author

turkenf commented Mar 20, 2024

/test-examples="examples/app/roleassignment.yaml"

Uptest run: https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/8361272313

@turkenf
Copy link
Collaborator Author

turkenf commented Mar 20, 2024

/test-examples="examples/applications/certificate.yaml"

Uptest run: https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/8361275370

@turkenf
Copy link
Collaborator Author

turkenf commented Mar 20, 2024

/test-examples="examples/directoryroles/role.yaml"

Uptest run: https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/8361280155

@turkenf
Copy link
Collaborator Author

turkenf commented Mar 20, 2024

/test-examples="examples/groups/member.yaml"

Need permissions

@turkenf turkenf marked this pull request as ready for review March 20, 2024 15:36
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf LGTM! Could you please left a comment about the reason of the failure test before merging the PR.

@@ -4,13 +4,15 @@

module github.com/upbound/provider-azuread

go 1.21
go 1.21.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the reason for this patch version pin is here.

@turkenf
Copy link
Collaborator Author

turkenf commented Mar 20, 2024

The creation and import part of the Member.groups resource passed successfully, but the uptest failed due to a lack of permissions in the deletion part.

Uptest run: https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/8361287843

@turkenf turkenf merged commit b37d059 into crossplane-contrib:main Mar 20, 2024
14 of 15 checks passed
@turkenf turkenf deleted the update-tf-provider-2.47.0 branch March 20, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants