-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump upjet to the latest commit #133
Conversation
/test-examples="examples/applications/v1beta2/application.yaml" |
/test-examples="examples/applications/v1beta2/application.yaml" |
/test-examples="examples/applications/v1beta2/application.yaml" |
Signed-off-by: Sergen Yalçın <[email protected]>
/test-examples="examples/conditionalaccess/v1beta2/accesspolicy.yaml" |
/test-examples="examples/applications/v1beta2/application.yaml" |
/test-examples="examples/conditionalaccess/v1beta2/location.yaml" |
/test-examples="examples/groups/v1beta2/group.yaml" |
/test-examples="examples/serviceprincipals/v1beta2/principal.yaml" |
/test-examples="examples/groups/v1beta1/member.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sergenyalcin, lgtm.
@@ -139,10 +139,11 @@ func bumpVersionsWithEmbeddedLists(pc *ujconfig.Provider) { | |||
// we would like to set the storage version to v1beta1 to facilitate | |||
// downgrades. | |||
r.SetCRDStorageVersion("v1beta1") | |||
r.ControllerReconcileVersion = "v1beta1" | |||
r.Conversions = []conversion.Conversion{ | |||
conversion.NewIdentityConversionExpandPaths(conversion.AllVersions, conversion.AllVersions, []string{"spec.forProvider", "spec.initProvider", "status.atProvider"}, r.CRDListConversionPaths()...), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We can also update the string literals for the three API roots here. But let's keep the tested state and we can do this in a follow-up PR if you also prefer.
Description of your changes
This PR bumps the upjet dependency to the latest commit
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
examples/applications/v1beta2/application.yaml: https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/9111424565
examples/conditionalaccess/v1beta2/accesspolicy.yaml: https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/9111126161
examples/conditionalaccess/v1beta2/location.yaml: https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/9111541469
examples/groups/v1beta2/group.yaml: https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/9111610387
examples/serviceprincipals/v1beta2/principal.yaml:
examples/groups/v1beta1/member.yaml: