-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standalone crddiff tool #165
Conversation
/test-examples="examples/conditionalaccess/v1beta2/accesspolicy.yaml" |
/test-examples="examples/applications/v1beta1/application.yaml" |
/test-examples="examples/conditionalaccess/v1beta2/accesspolicy.yaml" |
/test-examples="examples/applications/v1beta1/application.yaml" |
Signed-off-by: Fatih Türken <[email protected]>
/test-examples="examples/conditionalaccess/v1beta2/accesspolicy.yaml" https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/11616369681 |
/test-examples="examples/applications/v1beta1/application.yaml" https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/11616370685 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @turkenf 🙌 LGTM. For posterity, crddiff
used to be a command-line argument to uptest
. crddiff
didn't fit uptest
's purpose in the first place, so it was removed before donating uptest
to the community. Now that we have updated the build module to use crossplane/build, which doesn't have crddiff
, we are running it from upbound/uptest.
Description of your changes
This PR uses the standalone
crddiff
tool.I have:
make reviewable
to ensure this PR is ready for review.Addedbackport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Tested with the uptest in the below comments.