Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use commenter's repository permissions instead of author association. #208

Merged

Conversation

jastang
Copy link
Contributor

@jastang jastang commented Feb 28, 2025

Description of your changes

Determine appropriate access for comment-based workflow triggers based on the commenter's repository-level permission, rather than author association (which is a non-intuitive derivation based on membership in the GitHub organization in addition to repository-level permissions).

This aims to ensure trusted actors are able to run their e2e workflows in repositories they maintain, without necessarily requiring membership in the crossplane-contrib organization.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Tested in a personal fork of the repository. This is the first standalone repository to try adapting this pattern -- this will need to be updated in multiple other repositories including the workflows-only repo that others inherit from.
[contribution process]: https://git.io/fj2m9

@jastang
Copy link
Contributor Author

jastang commented Feb 28, 2025

If we want to be fancy we can have this reply to the comment if the user does not have sufficient permissions but that can be outside the scope of this change.

@jeanduplessis jeanduplessis merged commit a131b54 into crossplane-contrib:main Feb 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants